From: Heiko Hund
The size of the returned MULTI_SZ wide domains string was calculated
wrongly. Instead of adding the size of a WCHAR, only the size of a char
was used. As a result, the domains string was stored too short and was
missing the final string terminator.
DHCP assigned DNS server addre
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1026?usp=email
to look at the new patch set (#3).
Change subject: dns: fix potential NULL pointer dereferenc
Attention is currently required from: flichtenheld, plaisthos.
mattock has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1024?usp=email )
Change subject: t_server_null: print error when server startup fails
...
cron2 has uploaded a new patch set (#21) to the change originally created by
d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/905?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by stipa
Change subject: win: match search domains when creating exclude rules
...
Looks generally reasonable. Lev has tested this thoroughly and confirms
it works :-) - there is a bug in string length calculation in here
(wide/normal string) so the code as it stands does not work correctly
for multiple domains. To be fixed in the next patch (#1028).
I have only compile tested
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/905?usp=email )
Change subject: win: match search domains when creating exclude rules
..
win: match search domains when creating exclude rules
Compare loc
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/1028?usp=email )
Change subject: win: fix collecting DNS exclude data
..
win: fix collecting DNS exclude data
The size of the returned MULTI_SZ wide domai
Explanation sounds very logical, code looks reasonable, and Lev has
verified that the NRPT exclude domains stuff indeed works now if
multiple domains are involved. Great :-)
Your patch has been applied to the master branch.
commit 21c8f820d15e7891b042d33cdd989316ed987dab
Author: Heiko Hund
Date
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1029?usp=email
to review the following change.
Change subject: Fix new doxygen warnings about using @return in void functions
Attention is currently required from: flichtenheld, mrbff, plaisthos.
Hello flichtenheld, plaisthos, stipa,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/810?usp=email
to look at the new patch set (#14).
The change is no longer submittable: checks~C
cron2 has uploaded a new patch set (#4) to the change originally created by
d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/1028?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by stipa
Change subject: win: fix collecting DNS exclude data
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1041?usp=email
to review the following change.
Change subject: Use mbedtls_ssl_export_keying_material()
..
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1042?usp=email
to review the following change.
Change subject: mbedtls: Allow TLS 1.3 if available
...
From: Heiko Hund
Compare local domains for exclude rules to search domains and skip
matching ones. This prevents the creation of exclude rules when the
server indicates that the domain should be resolved via the VPN, by
pushing the search domain.
Change-Id: I4919af2b845a47787c08f454b108ef376ea5c
cron2 has uploaded a new patch set (#4) to the change originally created by
d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/1026?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: dns: fix potential NULL pointer dereference
.
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1028?usp=email
to look at the new patch set (#2).
Change subject: win: fix collecting DNS exclude data
.
OpenVPN 3 Linux v24 (Bugfix/security release)
The v24.1 release is a small security and bugfix release.
* Security: CVE-2025-3908 - openvpn3-admin init-config follows symlink
Wolfgang Frisch from the SUSE security team reach out and
notified us of a potential issue with the openvpn3-admin ini
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1028?usp=email
to review the following change.
Change subject: win: fix collecting DNS exclude domains
...
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1028?usp=email
to look at the new patch set (#3).
Change subject: win: fix collecting DNS exclude data
.
Attention is currently required from: d12fk, flichtenheld, plaisthos.
stipa has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1028?usp=email )
Change subject: win: fix collecting DNS exclude data
..
P
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/1026?usp=email )
Change subject: dns: fix potential NULL pointer dereference
..
dns: fix potential NULL pointer dereference
Fix issue reported by Coverity
Thanks for this.
Found by Coverity - in the case of a problem in platform_create_temp_file(),
the old code would have accessed strlen(NULL) and *boom*. Unlikely, but
arguably still possible if something changes with --tmpdir while openvpn
is running, or so.
Stared at code v2+v3, like v3 better :
Attention is currently required from: d12fk, flichtenheld, plaisthos.
stipa has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/905?usp=email )
Change subject: win: match search domains when creating exclude rules
..
From: Heiko Hund
Fix issue reported by Coverity (CID 1646952): Dereferencing a pointer
that might be NULL dvf when calling env_set_write_file.
In addition to the fix, inline the write_dns_vars_file() helper function.
Also output a log line in case this error happens, because when it
happens it w
Attention is currently required from: d12fk, flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1026?usp=email )
Change subject: dns: fix potential NULL pointer dereference
...
Attention is currently required from: cron2, flichtenheld, mrbff, plaisthos.
Hello cron2, flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/869?usp=email
to look at the new patch set (#6).
The following approvals got outdated an
Attention is currently required from: flichtenheld, mrbff, plaisthos.
Hello flichtenheld, plaisthos, stipa,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/809?usp=email
to look at the new patch set (#14).
The change is no longer submittable: checks~C
Attention is currently required from: flichtenheld, mattock, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1024?usp=email )
Change subject: t_server_null: print error when server startup fails
28 matches
Mail list logo
