Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1026?usp=email
to review the following change.
Change subject: dns: fix potential NULL pointer dereference
...
cron2 has uploaded a new patch set (#5) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/945?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: Make --dh none behaviour default if not specified
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/945?usp=email )
Change subject: Make --dh none behaviour default if not specified
..
Make --dh none behaviour default if not specified
Nowadays ciphers th
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1027?usp=email
to review the following change.
Change subject: dco_linux: print meaningful text when netlink m
Attention is currently required from: flichtenheld, plaisthos, stipa.
d12fk has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/904?usp=email )
Change subject: dns: deal with --dhcp-options when --dns is active
.
Attention is currently required from: mattock, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1024?usp=email )
Change subject: t_server_null: print error when server startup fails
...
This patch doesn't actually change very much, except no longer requiring
an explicit "--dh none" for deployments that do not need DH params
(like, everything recent). So this is mostly documentation and a very
small code change ("none" maps to "dh_file = NULL", and not setting
anything defaults to
cron2 has uploaded a new patch set (#3) to the change originally created by
ordex. ( http://gerrit.openvpn.net/c/openvpn/+/907?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: socket: don't transfer bind family to socket in case of AN
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/907?usp=email )
Change subject: socket: don't transfer bind family to socket in case of ANY
address
..
socket: don't transfer bind family to socket in cas
This was +2'ed long ago, but got left rotting due to "I need to find a
meaningful test case"... well, I give up on this, because this is all
very obscure corner cases (setting lport != 0, but not setting a
--local address to bind to, and the OS serving us a v6 ANY, breaking
connection to a v4 host
Attention is currently required from: flichtenheld, ordex, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1027?usp=email )
Change subject: dco_linux: print meaningful text when netlink message is not
parsed
..
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/848?usp=email )
Change subject: Doxygen: Fix missing parameter warnings
..
Patch Set 5:
From: Frank Lichtenheld
This fixes almost all of the remaining warnings in our
doxygen. Mostly about missing parameters in otherwise
documented functions (completely undocumented functions
do not cause warnings).
Other changes:
- Exclude out/ directory (used by CMakePresets.json)
- Output doxy
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1026?usp=email
to look at the new patch set (#2).
Change subject: dns: fix potential NULL pointer dereferenc
Attention is currently required from: flichtenheld.
Hello plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/848?usp=email
to look at the new patch set (#6).
The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now.
Ch
From: Frank Lichtenheld
This fixes almost all of the remaining warnings in our
doxygen. Mostly about missing parameters in otherwise
documented functions (completely undocumented functions
do not cause warnings).
Other changes:
- Exclude out/ directory (used by CMakePresets.json)
- Output doxy
Thanks. Documentation improvements are always good :-)
As for the readers that wonder what v5..v6 was about - rebase, context
changed in tls_crypt.h, and "git am" did not know what to do with it,
while "git rebase" and gerrit handled it just fine... sorry for the
extra noise on the list.
Your pa
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/848?usp=email )
Change subject: Doxygen: Fix missing parameter warnings
..
Doxygen: Fix missing parameter warnings
This fixes almost all of the remaining
cron2 has uploaded a new patch set (#7) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/848?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: Doxygen: Fix missing parameter warnings
...
Attention is currently required from: d12fk, flichtenheld, plaisthos.
stipa has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/905?usp=email )
Change subject: win: match search domains when creating exclude rules
..
20 matches
Mail list logo
