Hi,
On Wed, May 07, 2025 at 10:56:32AM +0200, Antonio Quartulli wrote:
> Clear the IFF_XMIT_DST_RELEASE flag during interface setup to allow
> the route entry (skb's dst) to survive and thus be inspected
> by the routing logic.
Tested, fixes the problem I reported in
https://github.com/OpenVPN
Hi,
On Wed, May 07, 2025 at 04:02:54PM +0200, Gert Doering wrote:
> Tested, works :-) - so the previous behaviour was "oping was hanging
> due to 'out of buffer space' error not being counted as 'packet sent'"
> and now it's behaving as any regular network interface when there
> is no ARP/IPv6 ND
Hi,
On Tue, May 06, 2025 at 12:55:49AM +0200, Antonio Quartulli wrote:
> From: Antonio Quartulli
>
> In case of UDP peer timeout, an openvpn client (userspace)
> performs the following actions:
> 1. receives the peer deletion notification (reason=timeout)
> 2. closes the socket
[..]
>
> Signed-
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/981?usp=email )
Change subject: CMake: Make sure to treat UNIT_TEST_SOURCEDIR as path
..
Hi,
On Wed, May 07, 2025 at 02:44:39PM +0200, Antonio Quartulli wrote:
> From: Antonio Quartulli
>
> ndo_start_xmit is basically expected to always return NETDEV_TX_OK.
> However, in case of error, it was currently returning NET_XMIT_DROP,
> which is not a valid netdev_tx_t return value, leading
From: Antonio Quartulli
When routing a packet to a LAN behind a peer, ovpn need to
inspect the route entry that brought there the packet in the
first place.
If this packet is truly routable, the route will provide the
GW to be used to lookup the VPN peer to send the packet to.
However, the rout
From: Frank Lichtenheld
This makes sure that it is properly normalized, and
on Windows seems to prevent CMake from using back
slashes which would break the build due to "unknown escape
sequence" errors.
Change-Id: I2551edfaaf5107649398a3fa1db2009ee8644671
Signed-off-by: Frank Lichtenheld
Acked-
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/981?usp=email
to review the following change.
Change subject: CMake: Make sure to treat UNIT_TEST_SOURCEDIR as path
..
I have no idea what this is about :-) - but it's fixing build fails for
"we want to do automated tests on windows VMs via GHA", so this is
important. No code change, only cmake build environment.
Your patch has been applied to the master branch.
commit b6af9b2841005cf139bf8d0c3ed40561903b59af
Au
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/981?usp=email )
Change subject: CMake: Make sure to treat UNIT_TEST_SOURCEDIR as path
..
CMake: Make sure to treat UNIT_TEST_SOURCEDIR as path
This makes
cron2 has uploaded a new patch set (#2) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/981?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: CMake: Make sure to treat UNIT_TEST_SOURCEDIR as pa
From: Antonio Quartulli
ndo_start_xmit is basically expected to always return NETDEV_TX_OK.
However, in case of error, it was currently returning NET_XMIT_DROP,
which is not a valid netdev_tx_t return value, leading to
misinterpretation.
Change ndo_start_xmit to always return NETDEV_TX_OK to sig
On 07/05/2025 08:49, Antonio Quartulli wrote:
Hi,
On 07/05/2025 08:45, Gert Doering wrote:
so:
Tested-By: Gert Doering
Acked-By: Gert Doering
Sending your tags this way is definitely the way to go.
I'll add them when pushing the patch to my tree.
Merged to main branch, commit id e2fb21d8
On 07/05/2025 11:11, Gert Doering wrote:
Hi,
On Wed, May 07, 2025 at 10:56:32AM +0200, Antonio Quartulli wrote:
Clear the IFF_XMIT_DST_RELEASE flag during interface setup to allow
the route entry (skb's dst) to survive and thus be inspected
by the routing logic.
Tested, fixes the problem I re
On 07/05/2025 16:36, Gert Doering wrote:
Hi,
On Wed, May 07, 2025 at 04:02:54PM +0200, Gert Doering wrote:
Tested, works :-) - so the previous behaviour was "oping was hanging
due to 'out of buffer space' error not being counted as 'packet sent'"
and now it's behaving as any regular network int
From: Walter Doekes
When you're connected to a VPN which is used as the default gateway, a
connection to a second VPN will cause a tunnel-in-tunnel traffic. If the
administrator of the second VPN wants to avoid that, by pushing its IP
as net_gateway, this means that the client's source IP switche
16 matches
Mail list logo