[Openvpn-devel] [XL] Change in openvpn[master]: Reformat the whole project with clang-format

2025-04-30 Thread flichtenheld (Code Review)
Attention is currently required from: ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/791?usp=email ) Change subject: Reformat the whole project with clang-format .. P

[Openvpn-devel] [PATCH ovpn-net-next 1/2] ovpn: don't access sk after release

2025-04-30 Thread Antonio Quartulli
From: Antonio Quartulli In case of UDP peer timeout, an openvpn client (userspace) performs the following actions: 1. receives the peer deletion notification (reason=timeout) 2. closes the socket 3. deletes the ovpn interface Upon 3. we have the following: - dellink() - cancel_delayed_work_sync

[Openvpn-devel] [PATCH ovpn-net-next 2/2] ovpn: drop useless reg_state check in keepalive worker

2025-04-30 Thread Antonio Quartulli
From: Antonio Quartulli The keepalive worker is cancelled before calling unregister_netdevice_queue(), therefore it will never hit a situation where the reg_state can be different than NETDEV_REGISTERED. For this reason, checking reg_state is useless and the condition can be removed. Signed-off

[Openvpn-devel] [M] Change in openvpn[master]: Define a .clang-format file for the project

2025-04-30 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/790?usp=email to look at the new patch set (#13). Change subject: Define a .clang-format file for the project ..