Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/940?usp=email
to review the following change.
Change subject: Remove UINT8_MAX definition
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/906?usp=email
to look at the new patch set (#3).
Change subject: win: allow OpenVPN service account to use a
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/906?usp=email )
Change subject: win: allow OpenVPN service account to use any command-line
options
..
win: allow OpenVPN service account to use any comman
cron2 has uploaded a new patch set (#5) to the change originally created by
stipa. ( http://gerrit.openvpn.net/c/openvpn/+/906?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: win: allow OpenVPN service account to use any command-line
op
This is part of a series of changes to make the "non-interactive
OpenVPN service" run itself + openvpn.exec without SYSTEM privileges,
using the iservice. This service needs more privileges than "joe random
user", especially "run config files from non-default directories", and
we can't add the ser
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/939?usp=email )
Change subject: Doxygen: Remove useless Python information
..
Patch Set
From: Lev Stipakov
Because this is a part of C99 if uint8_t is available.
Change-Id: I37482a8c322680add00bab52272f9945fbb3bd09
Signed-off-by: Lev Stipakov
Acked-by: Gert Doering
---
This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.
Ge
From: Lev Stipakov
Since 2.7, OpenVPN service (used to start persistent connections)
runs under limited virtual service account NT SERVICE\OpenVPNService.
Since it should be able to use all command-line options
and cannot be made member of "OpenVPN Administrators" group,
it has to be handled sep
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/936?usp=email )
Change subject: Doxygen: Clean up tls-crypt documentation
..
Patch Set 1
From: Frank Lichtenheld
- Fix broken links to OpenSSL documentation
- Remove some unnecessary \c for function names.
Doxygen does handle them automatically.
- Add some \c for --option since otherwise --
gets converted to one character (e.g. – in
HTML).
Change-Id: I9a27248557fabcd9f7584deb4
From: Frank Lichtenheld
Do not include information for the trivial Python
scripts we have. Completely eliminates the "Namespaces"
page as well.
Change-Id: Ia7186b528773c0549748f1051c1c8d1db39a7e11
Signed-off-by: Frank Lichtenheld
Acked-by: Arne Schwabe
---
This change was reviewed on Gerrit a
I'm not claiming to be an expert on Windows code and NRPT especially,
but I've stared hard at the code and this all seems to make sense
(including and especially memory and string handling). Lev tested
this in detail, I just compile tested.
(The code change to openvpn itself is fairly straightfor
Simple enough :-) - buildbots say that all supported platform are fine
with this change.
Your patch has been applied to the master branch.
commit ea1e6490a69b6209d6f972a50df8a0d05cb3d27e
Author: Lev Stipakov
Date: Tue Apr 15 17:52:53 2025 +0200
Remove UINT8_MAX definition
Signed-off
cron2 has uploaded a new patch set (#2) to the change originally created by
stipa. ( http://gerrit.openvpn.net/c/openvpn/+/940?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: Remove UINT8_MAX definition
..
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/940?usp=email )
Change subject: Remove UINT8_MAX definition
..
Remove UINT8_MAX definition
Because this is a part of C99 if uint8_t is available.
Change-
No code change, nothing to test for me :-) - Arne, thanks for the review.
Your patch has been applied to the master branch.
commit 0911d6e1a59e1566d984e2c75662dc7e407300e2
Author: Frank Lichtenheld
Date: Tue Apr 15 17:57:11 2025 +0200
Doxygen: Clean up tls-crypt documentation
Signed
cron2 has uploaded a new patch set (#2) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/936?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: Doxygen: Clean up tls-crypt documentation
.
And another one - no code change, nothing to test ;-)
Your patch has been applied to the master branch.
commit 78d0c15f48388c0d2376c12be47b0f8be98fac55
Author: Frank Lichtenheld
Date: Tue Apr 15 17:56:50 2025 +0200
Doxygen: Remove useless Python information
Signed-off-by: Frank Lich
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/936?usp=email )
Change subject: Doxygen: Clean up tls-crypt documentation
..
Doxygen: Clean up tls-crypt documentation
- Fix broken links to OpenSSL docum
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/939?usp=email )
Change subject: Doxygen: Remove useless Python information
..
Doxygen: Remove useless Python information
Do not include information for th
cron2 has uploaded a new patch set (#2) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/939?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: Doxygen: Remove useless Python information
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/906?usp=email
to look at the new patch set (#2).
Change subject: win: allow OpenVPN service account to use a
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/906?usp=email
to look at the new patch set (#4).
Change subject: win: allow OpenVPN service account to use a
Attention is currently required from: flichtenheld, plaisthos, stipa.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/940?usp=email )
Change subject: Remove UINT8_MAX definition
..
Patch Set 1
Attention is currently required from: d12fk, flichtenheld, plaisthos,
selvanair, stipa.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/906?usp=email )
Change subject: win: allow OpenVPN service account to use any command-line
options
.
25 matches
Mail list logo
