[Openvpn-devel] [PATCH applied] Re: GHA: Use CMake 4.0 and apply required fixes

2025-04-09 Thread Gert Doering
I have no idea what this all does, but Frank and Yuriy have, and GH confirms that "things build nicely". So in it goes. Your patch has been applied to the master branch. commit 3c6212588d5d73b46219d6223995acf9546693f2 Author: Frank Lichtenheld Date: Wed Apr 9 15:11:42 2025 +0200 GHA: Use

[Openvpn-devel] [S] Change in openvpn[master]: GHA: Use CMake 4.0 and apply required fixes

2025-04-09 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/934?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by uddr Change subject: GHA: Use CMake 4.0 and apply required fixes

[Openvpn-devel] [S] Change in openvpn[master]: GHA: Use CMake 4.0 and apply required fixes

2025-04-09 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/934?usp=email ) Change subject: GHA: Use CMake 4.0 and apply required fixes .. GHA: Use CMake 4.0 and apply required fixes - update vcpkg reference to 856

[Openvpn-devel] [S] Change in openvpn[master]: Fix dco_win and multisocket interaction

2025-04-09 Thread stipa (Code Review)
Attention is currently required from: its_Giaan, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/935?usp=email ) Change subject: Fix dco_win and multisocket interaction .. Patch Set

[Openvpn-devel] [PATCH applied] Re: Also print key agreement when printing negotiated details

2025-04-09 Thread Gert Doering
If everything works fine, nobody needs to look at this - but if things break, extra information is always good to have. I have stared at the code, and compared code & compat code with the OpenSSL documentation, and this all makes sense. The buildbots have tested it (t_client tests actually excerc

[Openvpn-devel] [S] Change in openvpn[master]: Fix dco_win and multisocket interaction

2025-04-09 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/935?usp=email ) Change subject: Fix dco_win and multisocket interaction .. Pa

[Openvpn-devel] [XL] Change in openvpn[master]: win: implement --dns option support with NRPT

2025-04-09 Thread stipa (Code Review)
Attention is currently required from: d12fk, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/837?usp=email ) Change subject: win: implement --dns option support with NRPT .. Patch S

[Openvpn-devel] [S] Change in openvpn[master]: Fix dco_win and multisocket interaction

2025-04-09 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/935?usp=email to look at the new patch set (#2). Change subject: Fix dco_win and multisocket inte

[Openvpn-devel] [XL] Change in openvpn[master]: win: implement --dns option support with NRPT

2025-04-09 Thread d12fk (Code Review)
Attention is currently required from: plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/837?usp=email ) Change subject: win: implement --dns option support with NRPT .. Patch Set 18:

[Openvpn-devel] [S] Change in openvpn[master]: Also print key agreement when printing negotiated details

2025-04-09 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/938?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Also print key agreement when printing negotiated details

[Openvpn-devel] [XL] Change in openvpn[master]: win: implement --dns option support with NRPT

2025-04-09 Thread d12fk (Code Review)
Attention is currently required from: plaisthos. d12fk has removed a vote from this change. ( http://gerrit.openvpn.net/c/openvpn/+/837?usp=email ) Change subject: win: implement --dns option support with NRPT .. Removed Code

[Openvpn-devel] [XS] Change in openvpn[master]: Doxygen: Fix obsolete links to OpenSSL documentation

2025-04-09 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/937?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Doxygen: Fix obsolete links to OpenSSL documentation ..

[Openvpn-devel] [XS] Change in openvpn[master]: Doxygen: Fix obsolete links to OpenSSL documentation

2025-04-09 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/937?usp=email ) Change subject: Doxygen: Fix obsolete links to OpenSSL documentation .. Doxygen: Fix obsolete links to OpenSSL documentation Change-Id: Ia

[Openvpn-devel] [PATCH v1] Also print key agreement when printing negotiated details

2025-04-09 Thread Gert Doering
From: Arne Schwabe With TLS 1.0 to 1.2, the used key agreement was depended on the certificates themselves. With TLS 1.3 is no longer the case but basically always X25519 was used. So this information has been very interesting so far. But with OpenSSL 3.5.0 and the new X25519MLKEM768 hybrid key a

[Openvpn-devel] [PATCH v1] GHA: Use CMake 4.0 and apply required fixes

2025-04-09 Thread Gert Doering
From: Frank Lichtenheld - update vcpkg reference to 856505bb76 This includes a general work-around for the CMake 4.0 compat. See commit a1aebfa9d5eae7cf493e0a706b43915d687bb860. - update lukka/get-cmake action to v4 - update dependency aws/aws-lc to v1.49.1 Change-Id: Ibabb4aa80d7786614dbd

[Openvpn-devel] [S] Change in openvpn[master]: Also print key agreement when printing negotiated details

2025-04-09 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/938?usp=email ) Change subject: Also print key agreement when printing negotiated details .. Also print key agreement when printing negotiated details Wit

[Openvpn-devel] [S] Change in openvpn[master]: Doxygen: Remove useless Python information

2025-04-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/939?usp=email to review the following change. Change subject: Doxygen: Remove useless Python information .

[Openvpn-devel] [XS] Change in openvpn[master]: Doxygen: Fix obsolete links to OpenSSL documentation

2025-04-09 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/937?usp=email ) Change subject: Doxygen: Fix obsolete links to OpenSSL documentation ..

[Openvpn-devel] [PATCH applied] Re: Doxygen: Fix obsolete links to OpenSSL documentation

2025-04-09 Thread Gert Doering
Change looks good, old URLs are broken and new URLs lead to meaningful content. No code change, so nothing to test. Mail-Archive.org is broken again (seems I get spamfiltered if I send too many patches their way...) so referencing sf.net archive for this. Your patch has been applied to the maste

[Openvpn-devel] [XS] Change in openvpn[master]: Doxygen: Fix obsolete links to OpenSSL documentation

2025-04-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/937?usp=email to review the following change. Change subject: Doxygen: Fix obsolete links to OpenSSL documentation ...

[Openvpn-devel] [S] Change in openvpn[master]: Fix dco_win and multisocket interaction

2025-04-09 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/935?usp=email ) Change subject: Fix dco_win and multisocket interaction

[Openvpn-devel] [S] Change in openvpn[master]: Fix dco_win and multisocket interaction

2025-04-09 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/935?usp=email ) Change subject: Fix dco_win and multisocket interaction

[Openvpn-devel] [S] Change in openvpn[master]: Also print key agreement when printing negotiated details

2025-04-09 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/938?usp=email to review the following change. Change subject: Also print key agreement when printing negotiated details

[Openvpn-devel] [S] Change in openvpn[master]: Doxygen: Clean up tls-crypt documentation

2025-04-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/936?usp=email to review the following change. Change subject: Doxygen: Clean up tls-crypt documentation ..

[Openvpn-devel] [S] Change in openvpn[master]: Also print key agreement when printing negotiated details

2025-04-09 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/938?usp=email ) Change subject: Also print key agreement when printing negotiated details .