[Openvpn-devel] [S] Change in openvpn[master]: Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid

2025-04-08 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#5) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/927?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by ordex Change subject: Use SSL_get0_peer_signature_name instead of SSL_get_peer_

[Openvpn-devel] [S] Change in openvpn[master]: Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid

2025-04-08 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/927?usp=email ) Change subject: Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid .. Use SSL_get0_peer_signature_name instead of SSL_

[Openvpn-devel] [PATCH applied] Re: Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid

2025-04-08 Thread Gert Doering
Good change. Use the 3.5 function if available, and move all the #ifdef mumbo to the compat header. Not explicitly tested, just stared a bit at the code & relied on the buildbot tests. Your patch has been applied to the master branch. commit b60d2bb98c77d5836b7e3e2d21eeeb17aa55d3f2 Author: Arne

[Openvpn-devel] [S] Change in openvpn[master]: GHA: Use CMake 4.0 and apply required fixes

2025-04-08 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/934?usp=email to review the following change. Change subject: GHA: Use CMake 4.0 and apply required fixes

[Openvpn-devel] [S] Change in openvpn[master]: GHA: Use CMake 4.0 and apply required fixes

2025-04-08 Thread uddr (Code Review)
Attention is currently required from: flichtenheld, plaisthos. uddr has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/934?usp=email ) Change subject: GHA: Use CMake 4.0 and apply required fixes .. Pat