[Openvpn-devel] [XS] Change in openvpn[master]: win: calculate address string buffer size

2025-04-04 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/908?usp=email ) Change subject: win: calculate address string buffer size .. Patc

[Openvpn-devel] [XL] Change in openvpn[master]: win: implement --dns option support with NRPT

2025-04-04 Thread d12fk (Code Review)
Attention is currently required from: plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/837?usp=email ) Change subject: win: implement --dns option support with NRPT .. Patch S

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-04-04 Thread d12fk (Code Review)
Attention is currently required from: cron2, d12fk, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to look at the new patch set (#20). The change is no longer submittable: checks~ChecksSu

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down command with privsep

2025-04-04 Thread d12fk (Code Review)
Attention is currently required from: MaxF, d12fk, plaisthos. Hello MaxF, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email to look at the new patch set (#20). The change is no longer submittable: checks~ChecksSubm

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-04-04 Thread d12fk (Code Review)
Attention is currently required from: cron2, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email ) Change subject: dns: apply settings via script on unixoid systems .. Pat

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down command with privsep

2025-04-04 Thread d12fk (Code Review)
Attention is currently required from: MaxF, d12fk, plaisthos. Hello MaxF, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email to look at the new patch set (#21). The change is no longer submittable: checks~ChecksSubm

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: GHA: Pin version of CMake for MinGW build

2025-04-04 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/930?usp=email ) Change subject: GHA: Pin version of CMake for MinGW build .. GHA: Pin version of CMake for MinGW build Turns out that "apt install cmake"

[Openvpn-devel] [PATCH applied] Re: GHA: Pin version of CMake for MinGW build

2025-04-04 Thread Gert Doering
Fairly straightforward backport of the master commit da65c4fd (master has Android build, so that commit is longer). Tested via GHA push that built fine. Your patch has been applied to the release/2.6 branch. commit ca61164a10580baca96b2be8c53883023151aca5 Author: Frank Lichtenheld Date: Wed Ap

[Openvpn-devel] [XS] Change in openvpn[master]: manpage: fix HTML format for --local

2025-04-04 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/922?usp=email ) Change subject: manpage: fix HTML format for --local .. manpage: fix HTML format for --local Fix the HTML format for --local directive to

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: GHA: Pin version of CMake for MinGW build

2025-04-04 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/930?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: GHA: Pin version of CMake for MinGW build .

[Openvpn-devel] [XS] Change in openvpn[master]: manpage: fix HTML format for --local

2025-04-04 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/922?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by mattock Change subject: manpage: fix HTML format for --local ...

[Openvpn-devel] [PATCH applied] Re: manpage: fix HTML format for --local

2025-04-04 Thread Gert Doering
This is documentation only, no code to test - to the untrained eye, the change looks good, and Samuli confirmed that the HTML created is correct now. In it goes :-) Your patch has been applied to the master branch. commit a51fb119d7e9a9db9173a10f9e20a4035ca76bbe Author: Gianmarco De Gregori Date

[Openvpn-devel] [S] Change in openvpn[release/2.6]: GHA: Dependency and Actions update April 2025 (2.6)

2025-04-04 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/931?usp=email ) Change subject: GHA: Dependency and Actions update April 2025 (2.6) .. GHA: Dependency and Actions update April 2025 (2.6) - Update all ac

[Openvpn-devel] [PATCH applied] Re: GHA: Dependency and Actions update April 2025 (2.6)

2025-04-04 Thread Gert Doering
Basically the same patch as for master - tested via private GHA push, works. Your patch has been applied to the release/2.6 branch. commit 3d25fbe189443cfd18adbfd8b00a17bb24f2f6ce Author: Frank Lichtenheld Date: Wed Apr 2 17:44:01 2025 +0200 GHA: Dependency and Actions update April 2025 (

[Openvpn-devel] [S] Change in openvpn[release/2.6]: GHA: Dependency and Actions update April 2025 (2.6)

2025-04-04 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/931?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: GHA: Dependency and Actions update April 2025 (2.6) ...

[Openvpn-devel] [S] Change in openvpn[master]: GHA: Dependency and Actions update April 2025

2025-04-04 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/926?usp=email to review the following change. Change subject: GHA: Dependency and Actions update April 2025 ..

[Openvpn-devel] [M] Change in openvpn[master]: dev-tools/text-removal.sh: Script to remove usage of tchar.h

2025-04-04 Thread flichtenheld (Code Review)
flichtenheld has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/852?usp=email ) Change subject: dev-tools/text-removal.sh: Script to remove usage of tchar.h .. Abandoned Not actually required to commit script t

[Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Added update_option() function.

2025-04-04 Thread mrbff (Code Review)
Attention is currently required from: flichtenheld, mrbff, plaisthos. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/810?usp=email to look at the new patch set (#13). The change is no longer submittable: checks~C

[Openvpn-devel] [PATCH v1] GHA: Pin version of CMake for MinGW build

2025-04-04 Thread Gert Doering
From: Frank Lichtenheld Turns out that "apt install cmake" is useless since Github installs also CMake but not as a package. So make sure we control which CMake we get and not Github. Switch to get-cmake action (which also installs ninja) and remove the installation via apt. Backport from maste

[Openvpn-devel] [S] Change in openvpn[master]: GHA: Dependency and Actions update April 2025

2025-04-04 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/926?usp=email ) Change subject: GHA: Dependency and Actions update April 2025 .. Patch S