Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/927?usp=email
to review the following change.
Change subject: Use SSL_get0_peer_signature_name instead of
SSL_get_peer_signature_ni
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/928?usp=email
to review the following change.
Change subject: dco-win: Fix crash when cancelling pending opera
Attention is currently required from: flichtenheld, ordex.
ordex has uploaded a new patch set (#4) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/927?usp=email )
Change subject: Use SSL_get0_peer_signature_name instead of
SSL_get_peer_signature_nid
.
Attention is currently required from: flichtenheld, plaisthos.
ordex has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/927?usp=email )
Change subject: Use SSL_get0_peer_signature_name instead of
SSL_get_peer_signature_nid
...
From: Lev Stipakov
The OVERLAPPED structure must remain valid for the entire duration of an
asynchronous operation. Previously, when a TCP connection was pending
inside the NEW_PEER call, the OVERLAPPED structure was defined as a
local variable within dco_p2p_new_peer().
When CancelIo() was call
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/928?usp=email )
Change subject: dco-win: Fix crash when cancelling pending operation
..
dco-win: Fix crash when cancelling pending operation
The OVERLAPPE
I haven't tested it, just stared at the code, and test compiled with
mingw. The change itself is straightforward - move the OVERLAPPED
structure inside struct tuntap, so it will share the same lifetime
(diagnosing this from a crash trying to close tt->hand is more
impressive ;-) )
Reference URLs
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/929?usp=email
to review the following change.
Change subject: GHA: Pin version of CMake for all builds
...
From: Frank Lichtenheld
Turns out that "apt install cmake" is useless since
Github installs also CMake but not as a package. So
make sure we control which CMake we get and not
Github.
Switch to get-cmake action (which also installs ninja)
and remove the installation via apt.
Change-Id: Ief11d5d
From: Lev Stipakov
The OVERLAPPED structure must remain valid for the entire duration of an
asynchronous operation. Previously, when a TCP connection was pending
inside the NEW_PEER call, the OVERLAPPED structure was defined as a
local variable within dco_p2p_new_peer().
When CancelIo() was call
Github and Arne say "this is fine"... :-) (verified in my repo)
(It needed #929 to be "really fine", due to unexpected changes in the
GHA-provided Ubuntu image... thanks for nothing, GH)
Your patch has been applied to the master branch.
commit 0ffa7b57fdfb2658ae326baea0871ccca2c01b7d
Author: Fr
Thanks for fixing the Github-induced explosions... tested in my repo,
builds now succeed again. Back to #926...
Your patch has been applied to the master branch.
commit da65c4fdde20e36df38a90c1f1ef1d8ebf486c28
Author: Frank Lichtenheld
Date: Tue Apr 1 19:04:14 2025 +0200
GHA: Pin version
cron2 has uploaded a new patch set (#2) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/926?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: GHA: Dependency and Actions update April 2025
.
Attention is currently required from: flichtenheld.
ordex has uploaded a new patch set (#3) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/927?usp=email )
Change subject: Use SSL_get0_peer_signature_name instead of
SSL_get_peer_signature_nid
cron2 has uploaded a new patch set (#2) to the change originally created by
ordex. ( http://gerrit.openvpn.net/c/openvpn/+/911?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: socket: use remote proto when creating client sockets
Attention is currently required from: flichtenheld, plaisthos, stipa.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/928?usp=email )
Change subject: dco-win: Fix crash when cancelling pending operation
...
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/929?usp=email )
Change subject: GHA: Pin version of CMake for all builds
..
Patch
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/929?usp=email )
Change subject: GHA: Pin version of CMake for all builds
..
GHA: Pin version of CMake for all builds
Turns out that "apt install cmake" is
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/926?usp=email )
Change subject: GHA: Dependency and Actions update April 2025
..
GHA: Dependency and Actions update April 2025
- Fix Android build with ne
cron2 has uploaded a new patch set (#2) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/929?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: GHA: Pin version of CMake for all builds
..
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/911?usp=email )
Change subject: socket: use remote proto when creating client sockets
..
socket: use remote proto when creating client sockets
When creati
Attention is currently required from: flichtenheld, ordex.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/927?usp=email )
Change subject: Use SSL_get0_peer_signature_name instead of
SSL_get_peer_signature_nid
...
22 matches
Mail list logo
