[Openvpn-devel] [M] Change in openvpn[master]: dns: clean up --dhcp-options when --dns is active

2025-03-13 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/904?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed

[Openvpn-devel] [L] Change in openvpn[master]: dns: don't publish env vars to non-dns scripts

2025-03-13 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/840?usp=email to look at the new patch set (#14). The following approvals got outdated and were

[Openvpn-devel] [M] Change in openvpn[master]: win: match search domains when creating exclude rules

2025-03-13 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/905?usp=email ) Change subject: win: match search domains when creating exclude rules .

[Openvpn-devel] [L] Change in openvpn[master]: dns: don't publish env vars to non-dns scripts

2025-03-13 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/840?usp=email ) Change subject: dns: don't publish env vars to non-dns scripts .

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-13 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to look at the new patch set (#14). Change subject: dns: apply settings via script on unixoid

[Openvpn-devel] [XS] Change in openvpn[master]: win: calculate address string buffer size

2025-03-13 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/908?usp=email to review the following change. Change subject: win: calculate address string buffer size ..

[Openvpn-devel] [M] Change in openvpn[master]: win: match search domains when creating exclude rules

2025-03-13 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/905?usp=email to look at the new patch set (#3). Change subject: win: match search domains when creating exc

[Openvpn-devel] [PATCH applied] Re: dco: fix source IP selection when multihome

2025-03-13 Thread Gert Doering
At last :-) - thanks, Antonio for testing, thanks Quingfang for your patience. I haven't tested it (do I look like I understand DCO stuff? :-) ) but from looking at other places, "ipi_spec_dst" is what is used elsewhere as "this is our IP" as well ("dest" might be confusing here, but it's the "des