Tested with and without DCO on Ubuntu 20.04.
Not tested on FreeBSD (no TCP support in DCO) or Windows (in this
particular code path, it's a no-op call).
Your patch has been applied to the master branch.
commit 90d7881e32ec371874c020f756bd35d1959e9698
Author: Antonio Quartulli
Date: Sun Mar 9
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/842?usp=email )
Change subject: dco: pass remoteaddr only for UDP peers
..
dco: pass remoteaddr only for UDP peers
TCP connected sockets do not need any r
cron2 has uploaded a new patch set (#3) to the change originally created by
ordex. ( http://gerrit.openvpn.net/c/openvpn/+/842?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: dco: pass remoteaddr only for UDP peers
..
From: Frank Lichtenheld
This has been #if 0 for over a decade. Let's just
remove this.
Change-Id: If570253e57371e4126b0e8aa4c349e2051cb8b00
Signed-off-by: Frank Lichtenheld
Acked-by: Gert Doering
---
This change was reviewed on Gerrit and approved by at least one
developer. I request to merge
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/863?usp=email )
Change subject: Remove unused function check_subnet_conflict
..
P
Haven't tested this (beyond "does it compile") as there is not much to
test - the function called is completely #if 0'ed, and there are no side
effects in the calls.
I'm a bit sad to see it go (the idea behind it is useful), but it did not
work the way it was written, was not adjusted to recent up
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/832?usp=email )
Change subject: options: Cleanup and simplify options_postprocess_verify_ce
...
cron2 has uploaded a new patch set (#5) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/863?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: Remove unused function check_subnet_conflict
..
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/863?usp=email )
Change subject: Remove unused function check_subnet_conflict
..
Remove unused function check_subnet_conflict
This has been #if 0 for over
Attention is currently required from: d12fk, flichtenheld, plaisthos.
stipa has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/824?usp=email )
Change subject: dns: support multiple domains without DHCP
.
From: Heiko Hund
Instead of using wmic on Windows to set one (the first) DNS domain,
modify the registry directly and let the resolver know that something
changed.
This fixes that more than one search domain suffix could only be applied
when DHCP and the tap driver was used. Now this works as we
From: Heiko Hund
Instead of spawning a netsh process, set the name server addresses
directly in the registry hive of the VPN interface.
This is a first step to get rid of the use of command line tools in the
service and move to a more API driven style of modifying the VPN adapter
configuration.
Attention is currently required from: d12fk, flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/824?usp=email )
Change subject: dns: support multiple domains without DHCP
.
Attention is currently required from: flichtenheld, ordex, plaisthos, stipa.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/842?usp=email )
Change subject: dco: pass remoteaddr only for UDP peers
.
From: Antonio Quartulli
TCP connected sockets do not need any remote addr
because the destination is fixed.
For this reason we can avoid sending the remote addr
along the peer-new dco call.
This change is important on Linux because the new 'ovpn'
kernel module is stricter when it comes to accept
15 matches
Mail list logo
