[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to look at the new patch set (#12). Change subject: dns: apply settings via script on unixoid

[Openvpn-devel] [M] Change in openvpn[master]: Make recursive routing check more fine-grained

2025-03-06 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/903?usp=email to look at the new patch set (#2). Change subject: Make recursive routing check

[Openvpn-devel] [S] Change in openvpn[master]: dns: clean up --dhcp-options when --dns is active

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/904?usp=email to review the following change. Change subject: dns: clean up --dhcp-options when --dns is activ

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email ) Change subject: dns: apply settings via script on unixoid systems .. Patch Set

[Openvpn-devel] [PATCH v21] Add support for simultaneous use of UDP and TCP sockets

2025-03-06 Thread Gert Doering
From: Gianmarco De Gregori Add all the bound sockets to the event loop. The main server loop has been updated to handle both TCP and UDP connections. The hash function has also been modified to include the protocol during the creation of new client instances. There are also a couple of refinement

[Openvpn-devel] [L] Change in openvpn[master]: Add support for simultaneous use of UDP and TCP sockets

2025-03-06 Thread cron2 (Code Review)
Attention is currently required from: its_Giaan, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/764?usp=email ) Change subject: Add support for simultaneous use of UDP and TCP sockets ...

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down script with privsep

2025-03-06 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/839?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: dns: support running up/down script with privsep

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email ) Change subject: dns: apply settings via script on unixoid systems .

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down script with privsep

2025-03-06 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/839?usp=email ) Change subject: dns: support running up/down script with privsep ..

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email ) Change subject: dns: support multiple domains without DHCP .

[Openvpn-devel] [M] Change in openvpn[master]: Make recursive routing check more fine-grained

2025-03-06 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/903?usp=email to review the following change. Change subject: Make recursive routing check more fine-grained .

[Openvpn-devel] [M] Change in openvpn[master]: Rename occurences of 'struct link_socket' from 'ls' to 'sock'

2025-03-06 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#8) to the change originally created by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/874?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Rename occurences of 'struct link_socket' from 'ls' to 'so

[Openvpn-devel] [M] Change in openvpn[master]: Make recursive routing check more fine-grained

2025-03-06 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/903?usp=email ) Change subject: Make recursive routing check more fine-grained .

[Openvpn-devel] [PATCH applied] Re: Rename occurences of 'struct link_socket' from 'ls' to 'sock'

2025-03-06 Thread Gert Doering
This is really just straightforward renaming of the "remaining pieces" - some of these "link_socket" things have been touched by the multisocket patchset, and others not yet. I asked for the rest to be sent in a separate patch to untangle "straightforward renaming in unrelated code paths" from "a

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email ) Change subject: dns: support multiple domains without DHCP .

[Openvpn-devel] [M] Change in openvpn[master]: Rename occurences of 'struct link_socket' from 'ls' to 'sock'

2025-03-06 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/874?usp=email to look at the new patch set (#7). The change is no longer submittable: check

[Openvpn-devel] [L] Change in openvpn[master]: dns: do not use netsh to set name server addresses

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/825?usp=email to look at the new patch set (#12). The change is no longer submittable: checks~C

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down script with privsep

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: MaxF, d12fk, plaisthos. Hello MaxF, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed:

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Code

[Openvpn-devel] [L] Change in openvpn[master]: dns: don't publish env vars to non-dns scripts

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: d12fk, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/840?usp=email to look at the new patch set (#11). Change subject: dns: don't publish env vars to non-dns scripts ..