Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/888?usp=email
to review the following change.
Change subject: Fix oversight of link socket code change in Android code path
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/890?usp=email
to review the following change.
Change subject: Always use a 0.0.0.0/0 default on Android instead of def1
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/891?usp=email
to review the following change.
Change subject: Reconnect when TCP is on use on network-change management
command
...
From: Arne Schwabe
This is a code path that only affects Android
Change-Id: I3f05318fb6f8d9e32d07532a4f0c6ccf8fb757ce
Signed-off-by: Arne Schwabe
Acked-by: Gert Doering
---
This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.
Gerrit URL:
From: Arne Schwabe
Commit 94b391d7ef5 changed context->link_socket to context->link_sockets
but did not change the Android code path.
Change-Id: If6a636b2099d948e249cf92ed2ba91d1698ee42f
Signed-off-by: Arne Schwabe
Acked-by: Gert Doering
---
This change was reviewed on Gerrit and approved by
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/889?usp=email )
Change subject: Fix typo in positive_atoi
..
Patch Set 1: Code-Re
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/888?usp=email )
Change subject: Fix oversight of link socket code change in Android code path
.
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/893?usp=email
to review the following change.
Change subject: GHA: Drop Ubuntu 20.04 and other maintenance (2.6)
.
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/892?usp=email
to review the following change.
Change subject: GHA: Drop Ubuntu 20.04 and other maintenance
...
cron2 has uploaded a new patch set (#2) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/888?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: Fix oversight of link socket code change in Android code p
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/888?usp=email )
Change subject: Fix oversight of link socket code change in Android code path
..
Fix oversight of link socket code change in Android code p
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/889?usp=email )
Change subject: Fix typo in positive_atoi
..
Fix typo in positive_atoi
This is a code path that only affects Android
Change-Id: I3f05318f
cron2 has uploaded a new patch set (#2) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/889?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: Fix typo in positive_atoi
Another one of those that we should have seen... sorry for that.
(I have not tested this, but it's inside #ifdef TARGET_ANDROID and
looks like the correct adjustment, so if Arne says "this makes it work"
it's good enough for me)
Your patch has been applied to the master branch.
commit 3ddfe26e4
Trivial typo... we should have caught that on merging the original
patch... but... new buildbot coming, I hear :-)
Your patch has been applied to the master branch.
commit f3268ee5c7a1beeea01aeed579c7ee11ceca9b03
Author: Arne Schwabe
Date: Wed Feb 12 13:36:52 2025 +0100
Fix typo in positi
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/889?usp=email
to review the following change.
Change subject: Fix typo in positive_atoi
Attention is currently required from: flichtenheld, plaisthos.
MaxF has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/806?usp=email )
Change subject: Implement epoch key data format
..
Patch Set 19: C
From: Arne Schwabe
With DCO and possible future hardware assisted OpenVPN acceleration we
are approaching the point where 32 bit IVs are not cutting it any more,
especially if we are limiting the IVs to the safe limits of AES-GCM where
the limit is more 2^29.
To illustrate the problem, some back
cron2 has uploaded a new patch set (#20) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/806?usp=email )
The following approvals got outdated and were removed:
Code-Review+1 by cron2, Code-Review+2 by MaxF
Change subject: Implement epoch key data format
..
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/806?usp=email )
Change subject: Implement epoch key data format
..
Implement epoch key data format
With DCO and possible future hardware assisted OpenVPN
Finally!
I think I've tested all there is in my repertoire (run this code against
itself and against earlier "non epoch" OpenVPN versions, both as client
and as server) - and managed to find a few nice explosions in v17+18 :-)
MaxF has done the crypto review, both on "is the OpenVPN protocol
docu
Attention is currently required from: flichtenheld, plaisthos.
uddr has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/893?usp=email )
Change subject: GHA: Drop Ubuntu 20.04 and other maintenance (2.6)
.
Attention is currently required from: flichtenheld, plaisthos.
uddr has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/892?usp=email )
Change subject: GHA: Drop Ubuntu 20.04 and other maintenance
..
Pa
From: Frank Lichtenheld
- Drop Ubuntu 20.04
GHA runners will go away in April 2025
- Change ubuntu-latest to ubuntu-24.04
to make sure we are not surprised by
future changes.
- Update vcpkg digest to latest 33e9c99
- Update github actions to latest
Backport changes:
Sync 2.6 GHA with maste
From: Frank Lichtenheld
- Drop Ubuntu 20.04
GHA runners will go away in April 2025
- Change ubuntu-latest to ubuntu-24.04
to make sure we are not surprised by
future changes.
- Update vcpkg digest to latest 33e9c99
- Update github actions to latest
Change-Id: I29b68675143988c3304395d9d5ec6
25 matches
Mail list logo
