Remove the old "read /proc/net/route and try to parse it" implementation
and always use the sitnl/netlink implementation of net_route_v4_best_gw().
This was kept "because we had it and it was working" but does not really
provide any benefit - netlink for route queries is there for v6 anyway,
and t
This adds Linux/SITNL platform functionality to the framework started by
commit 9df51cf56 and commit 0fcfc8381f.
v2: make comment reflect reality
Change-Id: I1db72d7dca648a8ea4ec65d173290a819971305c
Signed-off-by: Gert Doering
Acked-by: Antonio Quartulli
---
This change was reviewed on Gerrit
Attention is currently required from: cron2, flichtenheld, plaisthos.
ordex has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/883?usp=email )
Change subject: get_default_gateway(): implement platform support for
Linux/SITNL
.
Attention is currently required from: cron2, flichtenheld, plaisthos.
ordex has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/884?usp=email )
Change subject: get_default_gateway(): implement platform support for
Linux/IPROUTE2
..
Attention is currently required from: cron2, flichtenheld, plaisthos.
Hello flichtenheld, ordex, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/884?usp=email
to look at the new patch set (#2).
The change is no longer submittable: checks~Ch
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/883?usp=email
to look at the new patch set (#2).
Change subject: get_default_gateway(): implement platform s
Attention is currently required from: flichtenheld, plaisthos, stipa.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/879?usp=email )
Change subject: route.c: improve get_default_gateway() logic on Windows
Attention is currently required from: cron2, its_Giaan, plaisthos.
Hello cron2, flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/764?usp=email
to look at the new patch set (#18).
Change subject: Add support for simultaneous us
Attention is currently required from: cron2, plaisthos.
its_Giaan has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/764?usp=email )
Change subject: Add support for simultaneous use of UDP and TCP sockets
..
Attention is currently required from: cron2, flichtenheld, its_Giaan, plaisthos.
Hello cron2, flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/874?usp=email
to look at the new patch set (#4).
The following approvals got outdate
Attention is currently required from: flichtenheld, plaisthos, stipa.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/879?usp=email )
Change subject: route.c: improve get_default_gateway() logic on Windows
Attention is currently required from: flichtenheld, its_Giaan, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/874?usp=email )
Change subject: Rename occurences of 'struct link_socket' from 'ls' to 'sock'
..
Tested on a local gentoo system, with "the usual" questions
(--show-gateway, --show-gateway 127.0.0.1, --show-gateway , ...).
Patch has been applied to the master branch.
commit f28c254da58c7a48592c2c63c0a98b38283405e8
Author: Gert Doering
Date: Fri Jan 31 09:46:51 2025 +0100
get_default_
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/883?usp=email )
Change subject: get_default_gateway(): implement platform support for
Linux/SITNL
..
get_default_gateway(): implement platform support for
Hello flichtenheld, ordex, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/884?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+2 by ordex
Change subject: get_default_gateway()
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/884?usp=email )
Change subject: get_default_gateway(): implement platform support for
Linux/IPROUTE2
..
get_default_gateway(): implement platform support
Hello flichtenheld, ordex, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/883?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+2 by ordex
Change subject: get_default_gateway()
Tested on a gentoo system with "configure --enable-iproute2" and then
asking the usual "--show-gateway ..." questions.
The actual code change is quite trivial - throw out old code, rely on
the (by now) really well-tested and proven sitnl code.
Your patch has been applied to the master branch.
co
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa.
Hello cron2, flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/879?usp=email
to look at the new patch set (#3).
The following approvals got outdated an
Attention is currently required from: cron2, flichtenheld, plaisthos.
stipa has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/879?usp=email )
Change subject: route.c: improve get_default_gateway() logic on Windows
From: Lev Stipakov
When adding host route for IPv4, we use the default gateway. There are
cases, however, when this does not work - for example when remote
is not accessible via default gateway but via dedicated route.
Factor out code to look for the best gateway to reach the host from
get_defau
Attention is currently required from: flichtenheld, plaisthos, stipa.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/879?usp=email )
Change subject: route.c: improve get_default_gateway() logic on Windows
Tested a local windows build with this with various nasty questions
("--show-gateway 127.0.0.1", ON_LINK and not, etc) and v5 now gets us
the expected results for all my and Lev's tests. Plus, the code is much
more efficient on a system with many routes than "get all the tables
from Windows, and w
cron2 has uploaded a new patch set (#6) to the change originally created by
stipa. ( http://gerrit.openvpn.net/c/openvpn/+/879?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: route.c: improve get_default_gateway() logic on Windows
..
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/879?usp=email )
Change subject: route.c: improve get_default_gateway() logic on Windows
..
route.c: improve get_default_gateway() logic on Windows
When ad
Attention is currently required from: its_Giaan, ordex, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/764?usp=email )
Change subject: Add support for simultaneous use of UDP and TCP sockets
...
cron2 has uploaded a new patch set (#13) to the change originally created by
stipa. ( http://gerrit.openvpn.net/c/openvpn/+/814?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld, Code-Review+2 by ordex
Change subject: mudp.c: keep offset value when
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/814?usp=email )
Change subject: mudp.c: keep offset value when resetting buffer
..
mudp.c: keep offset value when resetting buffer
dco-win requires contro
When multihome option is enabled, OpenVPN passes ipi_addr to DCO, which
is always 0.0.0.0. It should use ipi_spec_dst instead.
When local option is present, OpenVPN does not pass it to DCO.
As a result, Linux may pick a different IP as the source IP, breaking
the connection.
Signed-off-by: Qingfan
Attention is currently required from: cron2, flichtenheld, plaisthos.
Hello cron2, flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/879?usp=email
to look at the new patch set (#4).
Change subject: route.c: improve get_default_
Attention is currently required from: cron2, flichtenheld, plaisthos.
Hello cron2, flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/879?usp=email
to look at the new patch set (#5).
Change subject: route.c: improve get_default_
Just for clarification: I'm taking the patch "v10" from the list, while
gerrit claims to have a "v12" - this is just due to rebasing and re-pushing,
but nothing at all has changed there.
I admit I haven't really closely looked what happens here, but it was
stared-at by Frank and Antonio, and both
URL: https://github.com/OpenVPN/openvpn/pull/673
Acked-by: Arne Schwabe
Signed-off-by: Shubham Mittal
---
.github/workflows/build.yaml | 62
1 file changed, 62 insertions(+)
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 90d52
33 matches
Mail list logo
