[Openvpn-devel] [M] Change in openvpn[master]: dco-win: factor out getting dco version

2024-12-29 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#6) to the change originally created by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/733?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: dco-win: factor out getting dco version ..

[Openvpn-devel] [M] Change in openvpn[master]: dco-win: factor out getting dco version

2024-12-29 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/733?usp=email ) Change subject: dco-win: factor out getting dco version .. dco-win: factor out getting dco version As a preparation for multipeer and data

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: simplify do_close_link_socket()

2024-12-29 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/813?usp=email ) Change subject: dco-win: simplify do_close_link_socket() ..

[Openvpn-devel] [PATCH v5] dco-win: factor out getting dco version

2024-12-29 Thread Gert Doering
From: Lev Stipakov As a preparation for multipeer and data_v3, add function which returns dco version in machine-readable format. Change-Id: I8e8ddd35bd3cc3334faf7f57118d1892512ae9f7 Signed-off-by: Lev Stipakov Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at l

[Openvpn-devel] [M] Change in openvpn[master]: dco-win: factor out getting dco version

2024-12-29 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/733?usp=email ) Change subject: dco-win: factor out getting dco version ..

[Openvpn-devel] [PATCH applied] Re: dco-win: factor out getting dco version

2024-12-29 Thread Gert Doering
Stared at code, had a few issues, those all got addressed. Stared again today (looks good). Test compiled on Ubuntu/MinGW, claims its happy. Your patch has been applied to the master branch. commit 10e785f1dcacdfd5240ac18a53f2839b4d3b979c (master) Author: Lev Stipakov Date: Sun Dec 29 15:17:5

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: enable mode server on supported configuration

2024-12-29 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/812?usp=email ) Change subject: dco-win: enable mode server on supported configuration .

[Openvpn-devel] [S] Change in openvpn[master]: [TEST-ONLY] Mess with internal logic to test epoch data

2024-12-29 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/818?usp=email ) Change subject: [TEST-ONLY] Mess with internal logic to test epoch data ...

[Openvpn-devel] [PATCH applied] Re: Improve shuffling algorithm of connection list

2024-12-29 Thread Gert Doering
Thanks for your patch. I have reformatted the comment section (line length was too long) and brought back the word "possibly" ("possibly randomize", it's not always randomized). I have not done any detailed tests on randomness and distribution of permutations, though :-) Your patch has been appl

[Openvpn-devel] [L] Change in openvpn[master]: Adapt socket handling to support listening on multiple sockets

2024-12-29 Thread cron2 (Code Review)
Attention is currently required from: its_Giaan, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/434?usp=email ) Change subject: Adapt socket handling to support listening on multiple sockets