[Openvpn-devel] [L] Change in openvpn[master]: options: Cleanup and simplify options_postprocess_verify_ce

2024-12-10 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/832?usp=email to review the following change. Change subject: options: Cleanup and simplify options_postprocess_verify_ce

[Openvpn-devel] [L] Change in openvpn[master]: Allow DEFAULT in data-ciphers and report both expanded and user set o...

2024-12-10 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/828?usp=email ) Change subject: Allow DEFAULT in data-ciphers and report both expanded and user set option ..

[Openvpn-devel] [M] Change in openvpn[master]: Handle missing DCO peer by restarting the session

2024-12-10 Thread ralf_lici (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/831?usp=email to review the following change. Change subject: Handle missing DCO peer by restarting the sessio

[Openvpn-devel] [L] Change in openvpn[master]: Allow DEFAULT in data-ciphers and report both expanded and user set o...

2024-12-10 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/828?usp=email to review the following change. Change subject: Allow DEFAULT in data-ciphers and report both expanded and user set o

Re: [Openvpn-devel] [PATCH v8] Use XOR instead of concatenation for calculation of IV from implicit IV

2024-12-10 Thread Gert Doering
Hi, On Tue, Dec 10, 2024 at 10:30:09AM +0100, Antonio Quartulli wrote: > My ACK got lost when v8 was created: > > Acked-by: Antonio Quartulli Thanks. Will record this on merge. Tests are running right now... gert -- "If was one thing all people took for granted, was conviction that if you

[Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Added remove_option() and do_update().

2024-12-10 Thread mrbff (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. mrbff has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/809?usp=email ) Change subject: PUSH_UPDATE: Added remove_option() and do_update().

[Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Added remove_option() and do_update().

2024-12-10 Thread mrbff (Code Review)
Attention is currently required from: flichtenheld, mrbff, plaisthos. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/809?usp=email to look at the new patch set (#9). Change subject: PUSH_UPDATE: Added remove_opt

[Openvpn-devel] [L] Change in openvpn[master]: Adapt socket handling to support listening on multiple sockets

2024-12-10 Thread its_Giaan (Code Review)
Attention is currently required from: cron2, ordex, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/434?usp=email ) Change subject: Adapt socket handling to support listening on multiple sockets

[Openvpn-devel] [S] Change in openvpn[master]: forward: Fix potential unaligned access in drop_if_recursive_routing

2024-12-10 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/827?usp=email to review the following change. Change subject: forward: Fix potential unaligned access in drop_if_recursive_routing ..

Re: [Openvpn-devel] [PATCH v8] Use XOR instead of concatenation for calculation of IV from implicit IV

2024-12-10 Thread Antonio Quartulli
On 09/12/2024 22:09, Gert Doering wrote: From: Arne Schwabe This change prepares the extended packet id data where also the packet id part of the IV will be derived using xor. Using xor also in the AEAD case where this degenerates to a concatenation allows using the same IV generation code lat