[Openvpn-devel] [M] Change in openvpn[master]: Haiku: Add calls to manage routing table

2024-12-05 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, kallisti5, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/688?usp=email ) Change subject: Haiku: Add calls to manage routing table ...

[Openvpn-devel] [PATCH v11] Haiku: Add calls to manage routing table

2024-12-05 Thread Gert Doering
From: Alexander von Gluck Signed-off-by: Alexander von Gluck Acked-by: Gert Doering Change-Id: I1a22724f28c5cd47f6df178b49f44087d7c2b6fd --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/ope

[Openvpn-devel] [M] Change in openvpn[master]: Haiku: Add calls to manage routing table

2024-12-05 Thread cron2 (Code Review)
Attention is currently required from: kallisti5. cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/688?usp=email ) Change subject: Haiku: Add calls to manage routing table .. Haiku: Add calls to manage ro

[Openvpn-devel] [PATCH applied] Re: Haiku: Add calls to manage routing table

2024-12-05 Thread Gert Doering
Thanks again for bringing OpenVPN to Haiku! On committing I've fixed a few more whitespace complaints from uncrustify (indenting and spaces around "*") that I did not spot in Gerrit - no code changes. I've added the pointer to the haiku reviews URL to the commit message, so people can see "ah, I

[Openvpn-devel] [M] Change in openvpn[master]: Haiku: Add calls to manage routing table

2024-12-05 Thread cron2 (Code Review)
Attention is currently required from: kallisti5. cron2 has uploaded a new patch set (#12) to the change originally created by kallisti5. ( http://gerrit.openvpn.net/c/openvpn/+/688?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by kallisti5, Code-Review+2 by cro

[Openvpn-devel] [S] Change in openvpn[master]: Fix some formatting related to if/else and macros

2024-12-05 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#4) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/821?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by stipa Change subject: Fix some formatting related to if/else and macros .

[Openvpn-devel] [S] Change in openvpn[master]: Fix some formatting related to if/else and macros

2024-12-05 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/821?usp=email ) Change subject: Fix some formatting related to if/else and macros .. Fix some formatting related to if/else and macros Make it clearer whe

[Openvpn-devel] [PATCH applied] Re: Fix some formatting related to if/else and macros

2024-12-05 Thread Gert Doering
.. because it makes sense, and is correct according to style guide (even if uncrustify cannot see it across the #ifdef maze). Thanks. Stared-at-code, especially for the init.c change (removing the #ifdef makes sense, as "management_flags" is always available). BB agrees that there are no compile

[Openvpn-devel] [L] Change in openvpn[master]: dns: do not use netsh to set name server addresses

2024-12-05 Thread stipa (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/825?usp=email ) Change subject: dns: do not use netsh to set name server addresses .

[Openvpn-devel] [PATCH v3] Fix some formatting related to if/else and macros

2024-12-05 Thread Gert Doering
From: Frank Lichtenheld Make it clearer where the blocks are. Change-Id: If645c3faf149bac82167a91be13541b30a1b8d6a Signed-off-by: Frank Lichtenheld Acked-by: Lev Stipakov --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit UR