Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/803?usp=email
to review the following change.
Change subject: Add methods to read/write packet ids for epoch data
..
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/802?usp=email
to review the following change.
Change subject: Change internal id of packet id to uint64
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/799?usp=email
to review the following change.
Change subject: Split init_key_ctx_bi into send/recv init
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/801?usp=email
to review the following change.
Change subject: Change API of init_key_ctx to use struct key_paramters
...
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/798?usp=email
to review the following change.
Change subject: Implement HKDF expand function based on RFC 8446
.
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/804?usp=email
to review the following change.
Change subject: Implement methods to generate and manage OpenVPN Epoch keys
..
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/806?usp=email
to review the following change.
Change subject: Implement epoch key data format
..
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/796?usp=email
to review the following change.
Change subject: Trigger renegotiation of data key if getting close to the AEAD
usage
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/800?usp=email
to review the following change.
Change subject: Move initialisation of implicit IVs to init_key_ctx_bi methods
...
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/794?usp=email
to review the following change.
Change subject: Move should_trigger_renegotiation into its own function
..
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/797?usp=email
to review the following change.
Change subject: Use XOR instead of concatenation for calculation of IV from
implicit
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/805?usp=email
to review the following change.
Change subject: Rename aead-tag-at-end to aead-epoch
.
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/795?usp=email
to review the following change.
Change subject: Change --reneg-bytes and --reneg-packets to 64 bit counters
..
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/794?usp=email )
Change subject: Move should_trigger_renegotiation into its own function
...
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/794?usp=email )
Change subject: Move should_trigger_renegotiation into its own function
...
From: Arne Schwabe
The if statement has become quite large and unreadable. Reformat it
and move it to a separate function.
Change-Id: I210fa255921e7115bd66ba5f3e431562552e3335
Signed-off-by: Arne Schwabe
Acked-by: Gert Doering
---
This change was reviewed on Gerrit and approved by at least on
16 matches
Mail list logo