[Openvpn-devel] [M] Change in openvpn[master]: Add methods to read/write packet ids for epoch data

2024-11-10 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/803?usp=email to review the following change. Change subject: Add methods to read/write packet ids for epoch data ..

[Openvpn-devel] [M] Change in openvpn[master]: Change internal id of packet id to uint64

2024-11-10 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/802?usp=email to review the following change. Change subject: Change internal id of packet id to uint64

[Openvpn-devel] [S] Change in openvpn[master]: Split init_key_ctx_bi into send/recv init

2024-11-10 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/799?usp=email to review the following change. Change subject: Split init_key_ctx_bi into send/recv init

[Openvpn-devel] [M] Change in openvpn[master]: Change API of init_key_ctx to use struct key_paramters

2024-11-10 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/801?usp=email to review the following change. Change subject: Change API of init_key_ctx to use struct key_paramters ...

[Openvpn-devel] [L] Change in openvpn[master]: Implement HKDF expand function based on RFC 8446

2024-11-10 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/798?usp=email to review the following change. Change subject: Implement HKDF expand function based on RFC 8446 .

[Openvpn-devel] [L] Change in openvpn[master]: Implement methods to generate and manage OpenVPN Epoch keys

2024-11-10 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/804?usp=email to review the following change. Change subject: Implement methods to generate and manage OpenVPN Epoch keys ..

[Openvpn-devel] [L] Change in openvpn[master]: Implement epoch key data format

2024-11-10 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/806?usp=email to review the following change. Change subject: Implement epoch key data format ..

[Openvpn-devel] [M] Change in openvpn[master]: Trigger renegotiation of data key if getting close to the AEAD usage ...

2024-11-10 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/796?usp=email to review the following change. Change subject: Trigger renegotiation of data key if getting close to the AEAD usage

[Openvpn-devel] [M] Change in openvpn[master]: Move initialisation of implicit IVs to init_key_ctx_bi methods

2024-11-10 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/800?usp=email to review the following change. Change subject: Move initialisation of implicit IVs to init_key_ctx_bi methods ...

[Openvpn-devel] [S] Change in openvpn[master]: Move should_trigger_renegotiation into its own function

2024-11-10 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/794?usp=email to review the following change. Change subject: Move should_trigger_renegotiation into its own function ..

[Openvpn-devel] [M] Change in openvpn[master]: Use XOR instead of concatenation for calculation of IV from implicit IV

2024-11-10 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/797?usp=email to review the following change. Change subject: Use XOR instead of concatenation for calculation of IV from implicit

[Openvpn-devel] [S] Change in openvpn[master]: Rename aead-tag-at-end to aead-epoch

2024-11-10 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/805?usp=email to review the following change. Change subject: Rename aead-tag-at-end to aead-epoch .

[Openvpn-devel] [S] Change in openvpn[master]: Change --reneg-bytes and --reneg-packets to 64 bit counters

2024-11-10 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/795?usp=email to review the following change. Change subject: Change --reneg-bytes and --reneg-packets to 64 bit counters ..

[Openvpn-devel] [S] Change in openvpn[master]: Move should_trigger_renegotiation into its own function

2024-11-10 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/794?usp=email ) Change subject: Move should_trigger_renegotiation into its own function ...

[Openvpn-devel] [S] Change in openvpn[master]: Move should_trigger_renegotiation into its own function

2024-11-10 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/794?usp=email ) Change subject: Move should_trigger_renegotiation into its own function ...

[Openvpn-devel] [PATCH v1] Move should_trigger_renegotiation into its own function

2024-11-10 Thread Gert Doering
From: Arne Schwabe The if statement has become quite large and unreadable. Reformat it and move it to a separate function. Change-Id: I210fa255921e7115bd66ba5f3e431562552e3335 Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least on