Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/788?usp=email
to review the following change.
Change subject: sitnl: replace NLMSG_TAIL macro with nlmsg_tail(
Attention is currently required from: flichtenheld, ordex, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/788?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/788?usp=email
to look at the new patch set (#2).
Change subject: sitnl: replace NLMSG_TAIL macro with noinli
Attention is currently required from: ordex, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/788?usp=email )
Change subject: sitnl: replace NLMSG_TAIL macro with noinline function
From: Antonio Quartulli
The NLMSG_TAIL macro never had any reason to exist, because libnl
already provides a function doing exactly the same: nlmsg_tail().
Moreover, this macro was found to confuse gcc when compiling with -O3,
which would result in subsequent warnings like:
networking_sitnl.c:1
