[Openvpn-devel] [S] Change in openvpn[master]: t_server_null: use wait instead of marker files

2024-10-26 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, mattock, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/786?usp=email ) Change subject: t_server_null: use wait instead of marker files ..

[Openvpn-devel] [S] Change in openvpn[master]: t_server_null: use wait instead of marker files

2024-10-26 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by mattock. ( http://gerrit.openvpn.net/c/openvpn/+/786?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: t_server_null: use wait instead of marker files

[Openvpn-devel] [PATCH applied] Re: t_server_null: use wait instead of marker files

2024-10-26 Thread Gert Doering
Tested on FreeBSD with the "this server is intentionally ignoring signals" patch, to make it fail. BB tested all the other platforms with well-behaved openvpn binaries. Your patch has been applied to the master branch. commit 5dd1b8b06335831206077a1eb4aa81c3ceb3f3ee Author: Samuli Seppänen Date:

[Openvpn-devel] [S] Change in openvpn[master]: t_server_null: use wait instead of marker files

2024-10-26 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/786?usp=email ) Change subject: t_server_null: use wait instead of marker files .. t_server_null: use wait instead of marker files By using wait in a more

[Openvpn-devel] [S] Change in openvpn[master]: Refuse clients if username or password is > USER_PASS_LEN

2024-10-26 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/787?usp=email ) Change subject: Refuse clients if username or password is > USER_PASS_LEN .

[Openvpn-devel] [S] Change in openvpn[master]: Refuse clients if username or password is > USER_PASS_LEN

2024-10-26 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/787?usp=email ) Change subject: Refuse clients if username or password is > USER_PASS_LEN .

[Openvpn-devel] [PATCH v1] t_server_null: use wait instead of marker files

2024-10-26 Thread Gert Doering
From: Samuli Seppänen By using wait in a more inventive way we can avoid using a marker file to detect the "server could not be killed gracefully" situation. Change-Id: Ib385080e1dd1c3046c54e6267db8aa7d5c09e2fb Signed-off-by: Samuli Seppänen Acked-by: Gert Doering --- This change was reviewed