[Openvpn-devel] [M] Change in openvpn[master]: Remove unused methods write_key/read_key

2024-10-18 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/784?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Remove unused methods write_key/read_key .

[Openvpn-devel] [M] Change in openvpn[master]: Remove unused methods write_key/read_key

2024-10-18 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/784?usp=email ) Change subject: Remove unused methods write_key/read_key .. Remove unused methods write_key/read_key These were used in the key-method 1 t

[Openvpn-devel] [PATCH applied] Re: Remove a large number of unused structs and functions

2024-10-18 Thread Gert Doering
Stared at the changes, scratched my head, checked individual "things" with "git grep", and also had GH do a test build on platforms that buildbot doesn't cover (BB is all green) - GH also all green. Your patch has been applied to the master branch. commit fcbb62375c3fe02549da57b05afb871bf44df338

[Openvpn-devel] [PATCH applied] Re: Remove unused methods write_key/read_key

2024-10-18 Thread Gert Doering
This one is quite straightforward... only sanity-checked (after staring at the code ;-) ) via a local build. Your patch has been applied to the master branch. commit 8ae409ad72a980d79dd8d40ab4284c3fab1efeb9 Author: Arne Schwabe Date: Fri Oct 18 08:31:23 2024 +0200 Remove unused methods w

[Openvpn-devel] [M] Change in openvpn[master]: Remove a large number of unused structs and functions

2024-10-18 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/783?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Remove a large number of unused structs and functions

[Openvpn-devel] [M] Change in openvpn[master]: Remove a large number of unused structs and functions

2024-10-18 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/783?usp=email ) Change subject: Remove a large number of unused structs and functions .. Remove a large number of unused structs and functions These have