[Openvpn-devel] [S] Change in openvpn[master]: t_client.sh: conditionally skip ifconfig+route check

2024-09-28 Thread cron2 (Code Review)
Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/768?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: t_client.sh: conditio

[Openvpn-devel] [S] Change in openvpn[master]: t_client.sh: conditionally skip ifconfig+route check

2024-09-28 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/768?usp=email ) Change subject: t_client.sh: conditionally skip ifconfig+route check .. t_client.sh: conditionally skip ifconfig+route check For --dev nul

[Openvpn-devel] [PATCH applied] Re: t_client.sh: conditionally skip ifconfig+route check

2024-09-28 Thread Gert Doering
Tested (quite a bit :-) ) in the testing phase of the AF_UNIX patch set... Patch has been applied to the master branch. commit 5ccaa49e0323ce468b156b3fa0930f7840050387 Author: Gert Doering Date: Sat Sep 28 22:05:08 2024 +0200 t_client.sh: conditionally skip ifconfig+route check Sign

[Openvpn-devel] [PATCH v2] t_client.sh: conditionally skip ifconfig+route check

2024-09-28 Thread Gert Doering
For --dev null or --dev-type af_unix:lwipopenvn tests, there will be no visible change to ifconfig or route output, so tests will fail ("how can this be?"). Set EXPECT_IFCONFIG4_=- to skip this check. (Simply leaving both EXPECT_IFCONFIG* vars empty and using that as trigger would interfere with