[Openvpn-devel] [L] Change in openvpn[master]: Interpret --key and --cert option argument as URI

2024-09-05 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, selvanair. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/726?usp=email ) Change subject: Interpret --key and --cert option argument as URI .

[Openvpn-devel] [S] Change in openvpn[master]: Add a test for loading certificate and key using file: URI

2024-09-05 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, selvanair. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/730?usp=email ) Change subject: Add a test for loading certificate and key using file: URI

[Openvpn-devel] [S] Change in openvpn[master]: proxy.c: Clear sensitive data after use

2024-09-05 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos, selvanair. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/727?usp=email ) Change subject: proxy.c: Clear sensitive data after use

[Openvpn-devel] [M] Change in openvpn[master]: Add a test for loading certificate and key to ssl context

2024-09-05 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, selvanair. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/729?usp=email ) Change subject: Add a test for loading certificate and key to ssl context .

[Openvpn-devel] [S] Change in openvpn[master]: tun: removed unnecessary route installations

2024-09-05 Thread flichtenheld (Code Review)
Attention is currently required from: mrbff, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/731?usp=email ) Change subject: tun: removed unnecessary route installations .. P

[Openvpn-devel] [PATCH v1] proxy.c: Clear sensitive data after use

2024-09-05 Thread Gert Doering
From: Selva Nair Usage of credentials is a bit odd in this file. Actually the copy of "struct user_pass" kept in p->up is not required at all. It just defeats the purpose of auth-nocahe as it never gets cleared. Removing it is beyond the scope of this patch -- we just ensure it's purged after u

[Openvpn-devel] [S] Change in openvpn[master]: route: copied 'gateway_needed' logic from add_route_ipv6 to add_route

2024-09-05 Thread flichtenheld (Code Review)
Attention is currently required from: mrbff, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/677?usp=email ) Change subject: route: copied 'gateway_needed' logic from add_route_ipv6 to add_route

[Openvpn-devel] [M] Change in openvpn[master]: Protect cached username, password and token on client

2024-09-05 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos, selvanair. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/728?usp=email ) Change subject: Protect cached username, password and token on client ..

[Openvpn-devel] [S] Change in openvpn[master]: route: copied 'gateway_needed' logic from add_route_ipv6 to add_route

2024-09-05 Thread mrbff (Code Review)
Attention is currently required from: flichtenheld, mrbff, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/677?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed

[Openvpn-devel] OpenVPN 3 Linux v23 released

2024-09-05 Thread David Sommerseth via Openvpn-devel
OpenVPN 3 Linux v23 (Stable release) The v23 release is stable release which expands the distribution target since v22_dev was released. The goal for this step was to stabilize the codebase which was migrated to GDBus++ and the new Meson building system. The next release (v24) will also be a st

[Openvpn-devel] [M] Change in openvpn[master]: Protect cached username, password and token on client

2024-09-05 Thread selvanair (Code Review)
Attention is currently required from: cron2, plaisthos, selvanair. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/728?usp=email to look at the new patch set (#3). Change subject: Protect cached username, passwor

[Openvpn-devel] [M] Change in openvpn[master]: Add a test for loading certificate and key to ssl context

2024-09-05 Thread selvanair (Code Review)
Attention is currently required from: plaisthos, selvanair. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/729?usp=email to look at the new patch set (#2). The change is no longer submittable: checks~ChecksSubmitRule is

[Openvpn-devel] [L] Change in openvpn[master]: Interpret --key and --cert option argument as URI

2024-09-05 Thread selvanair (Code Review)
Attention is currently required from: plaisthos, selvanair. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/726?usp=email to look at the new patch set (#3). The change is no longer submittable: checks~ChecksSubmitRule is

[Openvpn-devel] [S] Change in openvpn[master]: Add a test for loading certificate and key using file: URI

2024-09-05 Thread selvanair (Code Review)
Attention is currently required from: flichtenheld, plaisthos, selvanair. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/730?usp=email to look at the new patch set (#2). The following approvals got outdated and were rem

[Openvpn-devel] [L] Change in openvpn[master]: Interpret --key and --cert option argument as URI

2024-09-05 Thread selvanair (Code Review)
Attention is currently required from: plaisthos. selvanair has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/726?usp=email ) Change subject: Interpret --key and --cert option argument as URI .. Patch

[Openvpn-devel] [M] Change in openvpn[master]: Add a test for loading certificate and key to ssl context

2024-09-05 Thread selvanair (Code Review)
Attention is currently required from: plaisthos. selvanair has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/729?usp=email ) Change subject: Add a test for loading certificate and key to ssl context ..