[Openvpn-devel] [S] Change in openvpn[master]: Use a more robust way to get dco-win version

2024-08-09 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/723?usp=email to review the following change. Change subject: Use a more robust way to get dco-win version ...

[Openvpn-devel] [S] Change in openvpn[master]: Use a more robust way to get dco-win version

2024-08-09 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/723?usp=email ) Change subject: Use a more robust way to get dco-win version ...

[Openvpn-devel] [PATCH v1] Use a more robust way to get dco-win version

2024-08-09 Thread Gert Doering
From: Lev Stipakov The current way doesn't work if the device is already in use. Starting from 1.3.0, dco-win creates a non-exclusive control device \\.\ovpn-dco-ver which can be opened by multiple apps and supports a single IOCTL to get a version number. https://github.com/OpenVPN/ovpn-dco-win