[Openvpn-devel] [S] Change in openvpn[master]: route: copied 'gateway_needed' logic from add_route_ipv6 to add_route

2024-07-30 Thread mrbff (Code Review)
Attention is currently required from: flichtenheld, mrbff, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/677?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed

[Openvpn-devel] [L] Change in openvpn[master]: route: extended logic to omit gateway when unnecessary

2024-07-30 Thread ordex (Code Review)
ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/678?usp=email ) Change subject: route: extended logic to omit gateway when unnecessary .. Abandoned superseded by #721 (new change-id) -- To view, visit

[Openvpn-devel] [PATCH] examples: Switched to ed25519, nodes -> noenc

2024-07-30 Thread Eric Toombs via Openvpn-devel
From: Eric Toombs I switched the curve to ed25519, a generally more trustworthy curve and the default in openssh. As a bonus, it *really* simplifies what is already a complicated command. The old command wouldn't even run in all shells because it used process substitution. 'nodes' is deprecate

Re: [Openvpn-devel] [PATCH] examples: Switched to ed25519, nodes -> noenc

2024-07-30 Thread Arne Schwabe
Am 30.07.2024 um 19:00 schrieb Eric Toombs via Openvpn-devel: From: Eric Toombs We prefer real email addresses in our commits. I switched the curve to ed25519, a generally more trustworthy curve and the default in openssh. As a bonus, it *really* simplifies what is already a complicated com