[Openvpn-devel] [L] Change in openvpn[master]: Add support for TLV parsing in the PROXY protocol

2024-07-26 Thread ralf_lici (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/686?usp=email to review the following change. Change subject: Add support for TLV parsing in the PROXY protoco

[Openvpn-devel] [L] Change in openvpn[master]: Add support for HAProxy's PROXY protocol

2024-07-26 Thread ralf_lici (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/685?usp=email to review the following change. Change subject: Add support for HAProxy's PROXY protocol ...

[Openvpn-devel] [M] Change in openvpn[master]: console_systemd: rename query_user_exec to query_user_systemd

2024-07-26 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/670?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-

[Openvpn-devel] [S] Change in openvpn[master]: console_systemd: rename query_user_exec to query_user_systemd

2024-07-26 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/670?usp=email ) Change subject: console_systemd: rename query_user_exec to query_user_systemd .

[Openvpn-devel] [L] Change in openvpn[master]: Add support for HAProxy's PROXY protocol

2024-07-26 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, ralf_lici. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/685?usp=email ) Change subject: Add support for HAProxy's PROXY protocol .. P

[Openvpn-devel] [L] Change in openvpn[master]: Add support for TLV parsing in the PROXY protocol

2024-07-26 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, ralf_lici. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/686?usp=email ) Change subject: Add support for TLV parsing in the PROXY protocol .

[Openvpn-devel] [M] Change in openvpn[master]: console_systemd: rename query_user_exec to query_user_systemd

2024-07-26 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/670?usp=email ) Change subject: console_systemd: rename query_user_exec to query_user_systemd .

[Openvpn-devel] [M] Change in openvpn[master]: console_systemd: rename query_user_exec to query_user_systemd

2024-07-26 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/670?usp=email ) Change subject: console_systemd: rename query_user_exec to query_user_systemd .

[Openvpn-devel] [PATCH v4] console_systemd: rename query_user_exec to query_user_systemd

2024-07-26 Thread Gert Doering
From: Frank Lichtenheld This allows us to override query_user_exec for unit tests more consistently without having to jump through weird hoops. Fixes running test_pkcs11 with --enable-systemd. While here also fix documentation comments for query_user_exec*. Change-Id: I379e1eb6dc57b9fe4bbdaefb

[Openvpn-devel] [L] Change in openvpn[master]: Add support for HAProxy's PROXY protocol

2024-07-26 Thread plaisthos (Code Review)
Attention is currently required from: ralf_lici. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/685?usp=email ) Change subject: Add support for HAProxy's PROXY protocol .. Patch Set 1: Co

[Openvpn-devel] [M] Change in openvpn[master]: console_systemd: rename query_user_exec to query_user_systemd

2024-07-26 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#5) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/670?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: console_systemd: rename query_user_exec to query_user_s

[Openvpn-devel] [M] Change in openvpn[master]: console_systemd: rename query_user_exec to query_user_systemd

2024-07-26 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/670?usp=email ) Change subject: console_systemd: rename query_user_exec to query_user_systemd .. console_systemd: rename query_user_exec to query_user_syst

[Openvpn-devel] [PATCH applied] Re: console_systemd: rename query_user_exec to query_user_systemd

2024-07-26 Thread Gert Doering
Simplification of code, less #ifdef/#undef tricks, good :-) - stared at code, and compile tested (FreeBSD + GHA). Your patch has been applied to the master branch. commit 418463ad27c13f56adb5b02cfd62018b7d634ee8 (master) Author: Frank Lichtenheld Date: Fri Jul 26 12:40:32 2024 +0200 conso

[Openvpn-devel] [L] Change in openvpn[master]: Add support for HAProxy's PROXY protocol

2024-07-26 Thread ralf_lici (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ralf_lici has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/685?usp=email ) Change subject: Add support for HAProxy's PROXY protocol .. P