[Openvpn-devel] [PATCH v1] add and send IV_PROTO_DNS_OPTION_V2 flag

2024-07-25 Thread Gert Doering
From: Heiko Hund Incompatible changes to the --dns server address and --dns server exclude-domains options were introduced after the code for handling them was released. Add and send a new IV_PROTO flag, so servers which act on the flags set can differentiate between clients which have implemente

[Openvpn-devel] [PATCH applied] Re: add and send IV_PROTO_DNS_OPTION_V2 flag

2024-07-25 Thread Gert Doering
I have not tested this beyond "does it compile". My understanding is that this is to align openvpn 2.x and 3.x in regards to "if this bit is set, the client understands the new variants in `--dns`" and since the "new code" is only in master, so is this patch. Your patch has been applied to the ma

[Openvpn-devel] [XS] Change in openvpn[master]: add and send IV_PROTO_DNS_OPTION_V2 flag

2024-07-25 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/680?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: add and send IV_PROTO_DNS_OPTION_V2 flag .

[Openvpn-devel] [XS] Change in openvpn[master]: add and send IV_PROTO_DNS_OPTION_V2 flag

2024-07-25 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/680?usp=email ) Change subject: add and send IV_PROTO_DNS_OPTION_V2 flag .. add and send IV_PROTO_DNS_OPTION_V2 flag Incompatible changes to the --dns ser

[Openvpn-devel] [S] Change in openvpn[master]: console_systemd: rename query_user_exec to query_user_systemd

2024-07-25 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/670?usp=email ) Change subject: console_systemd: rename query_user_exec to query_user_systemd .