Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/679?usp=email
to review the following change.
Change subject: Fix missing spaces in various messages
.
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/679?usp=email )
Change subject: Fix missing spaces in various messages
..
Patch S
From: Frank Lichtenheld
These result from broken up literals where it
is easy to miss the missing space.
Change-Id: Ic27d84c74c1dd6ff7973ca6966d186f475c67e21
Signed-off-by: Frank Lichtenheld
Acked-by: Gert Doering
---
This change was reviewed on Gerrit and approved by at least one
developer.
Went through the individual messages, all very welcome fixes.
Test compiled, just to be sure no quote or anything escaped.
Your patch has been applied to the master and release/2.6 branch (bugfix).
commit 824fe9ce497bd26a9609abb7324427e906ead6a4 (master)
commit 02346806adafd3c656f018a7a1b3fb2c58
cron2 has uploaded a new patch set (#2) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/679?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: Fix missing spaces in various messages
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/679?usp=email )
Change subject: Fix missing spaces in various messages
..
Fix missing spaces in various messages
These result from broken up literals wher
Attention is currently required from: flichtenheld, its_Giaan, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/587?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were rem
Attention is currently required from: flichtenheld, plaisthos.
its_Giaan has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/587?usp=email )
Change subject: Ensures all params are ready before invoking dco_set_peer()
...
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/587?usp=email
to look at the new patch set (#4).
Change subject: Ensures all params are ready before invokin
Attention is currently required from: its_Giaan, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/587?usp=email )
Change subject: Ensures all params are ready before invoking dco_set_peer()
...
Your patch has been applied to the master branch.
I tried to apply it to release/2.6 as well, but the mbedtls builds
fail (on 24.04) with error messages like this:
crypto_backend.h:352:6: note: previous declaration of `cipher_ctx_init' with
type `void(cipher_ctx_t *, const uint8_t *, const char
cron2 has uploaded a new patch set (#2) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/676?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: Add Ubuntu 24.04 runner to Github Actions
.
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/676?usp=email )
Change subject: Add Ubuntu 24.04 runner to Github Actions
..
Add Ubuntu 24.04 runner to Github Actions
Change-Id: I44b9003143fdad90bfff7b2
13 matches
Mail list logo
