[Openvpn-devel] [L] Change in openvpn[master]: Turn dead list test code into unit test

2024-02-02 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/446?usp=email ) Change subject: Turn dead list test code into unit test .. Patch Set 3:

Re: [Openvpn-devel] [PATCH applied] Re: README.cmake.md: Document minimum required CMake version for --preset

2024-02-02 Thread Frank Lichtenheld
On Thu, Feb 01, 2024 at 08:28:21PM +0100, Gert Doering wrote: > Makes sense (I did read the GH issue). > > Your patch has been applied to the master branch. I think it would make sense to apply this to release/2.6 as well, since that uses the same CMake build. Thanks, -- Frank Lichtenheld _

[Openvpn-devel] [L] Change in openvpn[master]: Turn dead list test code into unit test

2024-02-02 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/446?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review-1 by

[Openvpn-devel] [L] Change in openvpn[master]: Turn dead list test code into unit test

2024-02-02 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/446?usp=email ) Change subject: Turn dead list test code into unit test .. Patch Set 4:

[Openvpn-devel] [L] Change in openvpn[master]: Implement support for larger packet counter sizes

2024-02-02 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/507?usp=email to look at the new patch set (#2). Change subject: Implement support for larger packet counter sizes ..

Re: [Openvpn-devel] [PATCH applied] Re: README.cmake.md: Document minimum required CMake version for --preset

2024-02-02 Thread Gert Doering
Hi, On Fri, Feb 02, 2024 at 12:27:19PM +0100, Frank Lichtenheld wrote: > On Thu, Feb 01, 2024 at 08:28:21PM +0100, Gert Doering wrote: > > Makes sense (I did read the GH issue). > > > > Your patch has been applied to the master branch. > > I think it would make sense to apply this to release/2.6