[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-09 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email ) Change subject: Windows: enforce 'block-local' with WFP filters ..

[Openvpn-devel] [XS] Change in openvpn[master]: forked-test-driver: Show test output always

2024-01-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/479?usp=email ) Change subject: forked-test-driver: Show test output always .. Patch Set

[Openvpn-devel] [S] Change in openvpn[master]: test_user_pass: Add UTs for character filtering

2024-01-09 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/473?usp=email to look at the new patch set (#5). The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now. Ch

[Openvpn-devel] [L] Change in openvpn[master]: test_user_pass: new UT for get_user_pass

2024-01-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/468?usp=email to look at the new patch set (#7). Change subject: test_user_pass: new UT for get_user_pass ..

[Openvpn-devel] [XS] Change in openvpn[master]: phase2_tcp_server: fix Coverity issue "Dereference after null check"

2024-01-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/490?usp=email to review the following change. Change subject: phase2_tcp_server: fix Coverity issue "Dereference after null check" ..

[Openvpn-devel] [S] Change in openvpn[master]: adjust_payload_max_cbc: Fix Coverity issue "Division or modulo by zero"

2024-01-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/492?usp=email to review the following change. Change subject: adjust_payload_max_cbc: Fix Coverity issue "Division or modulo by zero" ...

[Openvpn-devel] [S] Change in openvpn[master]: Fix various "Uninitialized scalar variable" warnings from Coverity

2024-01-09 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/318?usp=email to look at the new patch set (#2). The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now. Ch

[Openvpn-devel] [XS] Change in openvpn[master]: buf_string_match_head_str: Fix Coverity issue "Unsigned compared agai...

2024-01-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/491?usp=email to review the following change. Change subject: buf_string_match_head_str: Fix Coverity issue "Unsigned compared against 0"

[Openvpn-devel] [S] Change in openvpn[master]: adjust_payload_max_cbc: Fix Coverity issue "Division or modulo by zero"

2024-01-09 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/492?usp=email ) Change subject: adjust_payload_max_cbc: Fix Coverity issue "Division or modulo by zero" .

[Openvpn-devel] [S] Change in openvpn[master]: adjust_payload_max_cbc: Fix Coverity issue "Division or modulo by zero"

2024-01-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/492?usp=email ) Change subject: adjust_payload_max_cbc: Fix Coverity issue "Division or modulo by zero" .

[Openvpn-devel] [S] Change in openvpn[master]: adjust_payload_max_cbc: Fix Coverity issue "Division or modulo by zero"

2024-01-09 Thread flichtenheld (Code Review)
flichtenheld has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/492?usp=email ) Change subject: adjust_payload_max_cbc: Fix Coverity issue "Division or modulo by zero" .. Abandoned Cosmetic change only -- To v

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-09 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email ) Change subject: Windows: enforce 'block-local' with WFP filters

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-09 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email ) Change subject: Windows: enforce 'block-local' with WFP filters

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-09 Thread d12fk (Code Review)
Attention is currently required from: cron2, d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=email to look at the new patch set (#2). The following approvals got outdated and were

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-09 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email ) Change subject: Windows: enforce 'block-local' with WFP filters

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-09 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=email to look at the new patch set (#3). Change subject: Windows: enforce 'block-local' with

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-09 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email ) Change subject: Windows: enforce 'block-local' with WFP filters

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-09 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=email to look at the new patch set (#4). Change subject: Windows: enforce 'block-local' with