[Openvpn-devel] [M] Change in openvpn[master]: Move get_tmp_dir to win32-util.c and error out on failure

2024-01-06 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/481?usp=email ) Change subject: Move get_tmp_dir to win32-util.c and error out on failure .

[Openvpn-devel] [L] Change in openvpn[master]: Add test_ssl unit test and test export of PEM to file

2024-01-06 Thread cron2 (Code Review)
Attention is currently required from: plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/471?usp=email ) Change subject: Add test_ssl unit test and test export of PEM to file .. Patch

[Openvpn-devel] [M] Change in openvpn[master]: Implement the --tls-export-cert feature

2024-01-06 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/466?usp=email ) Change subject: Implement the --tls-export-cert feature .. Patch

[Openvpn-devel] [M] Change in openvpn[master]: Allow having an extra function that is called when an env is freed

2024-01-06 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/486?usp=email ) Change subject: Allow having an extra function that is called when an env is freed ...

Re: [Openvpn-devel] [PATCH applied] Re: Fix IPv6 route add/delete message log level

2024-01-06 Thread Gert Doering
Hi, On Fri, Jan 05, 2024 at 11:14:58PM +0100, Gert Doering wrote: > Patch looks good, makes sense, thanks for that. > > Interesting enough, the old code had weird formatting ("msg( M_INFO") > which led to weird indenting of the *next* lines - this patch changed > the msg() call to have no leading