[Openvpn-devel] [S] Change in openvpn[master]: GHA: clean up libressl builds with newer libressl

cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/461?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: GHA: clean up libressl builds with newer libressl .

[Openvpn-devel] [S] Change in openvpn[master]: GHA: clean up libressl builds with newer libressl

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/461?usp=email ) Change subject: GHA: clean up libressl builds with newer libressl .. GHA: clean up libressl builds with newer libressl - Update to latest

[Openvpn-devel] [PATCH applied] Re: GHA: clean up libressl builds with newer libressl

Your patch has been applied to the master and release/2.6 branch. Tested in my local GH repo, and only the expected failures (ASAN) were seen. commit 664dde85be91a5432efe52c90089fcf2bf5d6a3c (master) commit 1a6aef37781975ea9cc18dde6083ebb2683e6251 (release/2.6) Author: Frank Lichtenheld Date: F

[Openvpn-devel] [PATCH applied] Re: Remove unused/unneeded/add missing defines from configure/cmake

Removing all that autoconf cruft that we do not really care about is welcome :-) - a slightly more verbose commit message would have been nice ("remove readv/writev/vsnprintf check because we do not test for the result anyway, add getrlimit to cmake")... Your patch has been applied to the master b

[Openvpn-devel] [S] Change in openvpn[master]: Remove unused/unneeded/add missing defines from configure/cmake

cron2 has uploaded a new patch set (#6) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/443?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Remove unused/unneeded/add missing defines from con

[Openvpn-devel] [S] Change in openvpn[master]: Remove unused/unneeded/add missing defines from configure/cmake

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/443?usp=email ) Change subject: Remove unused/unneeded/add missing defines from configure/cmake .. Remove unused/unneeded/add missing defines from configur

[Openvpn-devel] [PATCH applied] Re: Document tls-exit option mainly as test option

Straight and to the point :-) Your patch has been applied to the master and release/2.6 branch. commit ee6417e9d602d7d2db018739f07724b4660bf980 (master) commit 350bdd85431548a7043085e475d6c8c611e2239f (release/2.6) Author: Arne Schwabe Date: Fri Dec 1 12:19:37 2023 +0100 Document tls-exit

[Openvpn-devel] [XS] Change in openvpn[master]: Document tls-exit option mainly as test option

cron2 has uploaded a new patch set (#4) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/447?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Document tls-exit option mainly as test option

[Openvpn-devel] [XS] Change in openvpn[master]: Document tls-exit option mainly as test option

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/447?usp=email ) Change subject: Document tls-exit option mainly as test option .. Document tls-exit option mainly as test option Change-Id: I93afff2372c41

[Openvpn-devel] [PATCH applied] Re: Remove dead remains of extract_x509_field_test

Obviously so :-) - haven't tested anything, as all removed code is insides #ifdef that are never defined (and the function body itself is long gone). Your patch has been applied to the master branch. commit 5ce74caa39cf6335bb4b5b394e1ac4da3c9b9a3f Author: Arne Schwabe Date: Fri Dec 1 12:18:46

[Openvpn-devel] [PATCH applied] Re: Replace character_class_debug with proper unit test

This is definitely more useful than having conditional tests that nobody ever runs... done a quick test on FreeBSD, passes... [ RUN ] test_character_class [ OK ] test_character_class [==] 14 test(s) run. [ PASSED ] 14 test(s). PASS: buffer_testdriver Your patch has been appli

[Openvpn-devel] [M] Change in openvpn[master]: Replace character_class_debug with proper unit test

cron2 has uploaded a new patch set (#2) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/464?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Replace character_class_debug with proper unit test

[Openvpn-devel] [XS] Change in openvpn[master]: Remove dead remains of extract_x509_field_test

cron2 has uploaded a new patch set (#2) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/462?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Remove dead remains of extract_x509_field_test

[Openvpn-devel] [M] Change in openvpn[master]: Replace character_class_debug with proper unit test

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/464?usp=email ) Change subject: Replace character_class_debug with proper unit test .. Replace character_class_debug with proper unit test Change-Id: Ib2a

[Openvpn-devel] [XS] Change in openvpn[master]: Remove dead remains of extract_x509_field_test

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/462?usp=email ) Change subject: Remove dead remains of extract_x509_field_test .. Remove dead remains of extract_x509_field_test This removes some leftove

[Openvpn-devel] [PATCH applied] Re: Remove TEST_GET_DEFAULT_GATEWAY as it duplicates --show-gateway

Wasn't even aware we had a TEST_... for this - and indeed, why, if we have a run-time-argument. But interestingly enough, seems I even added IPv6 default gateway handling to that dead function... thorough me. Your patch has been applied to the master and release/2.6 branch. commit 6158228f16836f

[Openvpn-devel] [S] Change in openvpn[master]: Remove TEST_GET_DEFAULT_GATEWAY as it duplicates --show-gateway

cron2 has uploaded a new patch set (#2) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/463?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Remove TEST_GET_DEFAULT_GATEWAY as it duplicates --

[Openvpn-devel] [S] Change in openvpn[master]: Remove TEST_GET_DEFAULT_GATEWAY as it duplicates --show-gateway

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/463?usp=email ) Change subject: Remove TEST_GET_DEFAULT_GATEWAY as it duplicates --show-gateway .. Remove TEST_GET_DEFAULT_GATEWAY as it duplicates --show-

[Openvpn-devel] [PATCH applied] Re: Fix check_session_buf_not_used using wrong index

Indeed, that function seems to be slightly cursed... and this is the right fix. For this bug. Tested more thoroughly :-) (full server test runs + GHA). Your patch has been applied to the master and release/2.6 branch. commit 59551b93cdb55397d63b2fe58ad99612821c0faf (master) commit 5def8d9353356

[Openvpn-devel] [XS] Change in openvpn[master]: Fix check_session_buf_not_used using wrong index

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/459?usp=email ) Change subject: Fix check_session_buf_not_used using wrong index .. Fix check_session_buf_not_used using wrong index The inner loop used i

[Openvpn-devel] [XS] Change in openvpn[master]: Fix check_session_buf_not_used using wrong index

cron2 has uploaded a new patch set (#2) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/459?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Fix check_session_buf_not_used using wrong index ..

[Openvpn-devel] [PATCH applied] Re: Add missing check for nl_socket_alloc failure

Took us long enough for such a simple fix... :-) I have no easy way to trigger this, so only compile tested. Your patch has been applied to the master and release/2.6 branch. commit d1c31e428120bb0fc9488c62c1691c92a37d94c3 (master) commit aa19a6a90f7ef24df12eed205663f3cfbb7d8174 (release/2.6) Au

[Openvpn-devel] [XS] Change in openvpn[master]: configure.ac: Remove unused AC_TYPE_SIGNAL macro

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/453?usp=email ) Change subject: configure.ac: Remove unused AC_TYPE_SIGNAL macro .. configure.ac: Remove unused AC_TYPE_SIGNAL macro Recent autoconf warns

[Openvpn-devel] [XS] Change in openvpn[master]: configure.ac: Remove unused AC_TYPE_SIGNAL macro

cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/453?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: configure.ac: Remove unused AC_TYPE_SIGNAL macro ..

[Openvpn-devel] [PATCH applied] Re: configure.ac: Remove unused AC_TYPE_SIGNAL macro

"makes sense" :-) - removing cruft from autoconf, and so on. Your patch has been applied to the master branch and release/2.6 (long-term compat). commit be05b590e8d5edebd8e35d97af34b0ba7e5350e6 (master) commit 64703e72df371dabecc8ab83a19621fd9f27c56b (release/2.6) Author: Frank Lichtenheld Date:

[Openvpn-devel] [XS] Change in openvpn[master]: Add check for nice in cmake config

cron2 has uploaded a new patch set (#4) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/444?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Add check for nice in cmake config

[Openvpn-devel] [PATCH applied] Re: Add check for nice in cmake config

Indeed, having that check would be nice :-) Your patch has been applied to the master and releae/2.6 branch (bugfix). commit 4d8ee61ce2c2a8b387773d33b4dd01bc2e147941 (master) commit cc81f014bcbcfb248fdae91dc3527565c5889ff4 (release/2.6) Author: Arne Schwabe Date: Tue Nov 28 11:41:29 2023 +0100

[Openvpn-devel] [XS] Change in openvpn[master]: Add check for nice in cmake config

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/444?usp=email ) Change subject: Add check for nice in cmake config .. Add check for nice in cmake config Change-Id: I2cc8f9b82079acca250db5871ffd9fad2997d

[Openvpn-devel] [PATCH applied] Re: Minimal Solaris/OpenIndiana support to Cmake and clean up -Werror

As this also affects TARGET_LINUX, compile-tested there and on GHA. Your patch has been applied to the master branch. commit efbedf213f659c48cfd55765360fdab7a6488dad (master) Author: Arne Schwabe Date: Tue Nov 28 12:14:47 2023 +0100 Minimal Solaris/OpenIndiana support to Cmake and clean u

[Openvpn-devel] [S] Change in openvpn[master]: Minimal Solaris/OpenIndiana support to Cmake and clean up -Werror

cron2 has uploaded a new patch set (#2) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/458?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Minimal Solaris/OpenIndiana support to Cmake and cl

[Openvpn-devel] [S] Change in openvpn[master]: Minimal Solaris/OpenIndiana support to Cmake and clean up -Werror

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/458?usp=email ) Change subject: Minimal Solaris/OpenIndiana support to Cmake and clean up -Werror .. Minimal Solaris/OpenIndiana support to Cmake and clea

[Openvpn-devel] [M] Change in openvpn[master]: Remove compat versionhelpers.h and remove cmake/configure check for it

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/445?usp=email ) Change subject: Remove compat versionhelpers.h and remove cmake/configure check for it .. Remove compat versionhelpers.h and remove cmake/

[Openvpn-devel] [PATCH applied] Re: Remove compat versionhelpers.h and remove cmake/configure check for it

Since this is sort of an extention to "The Cmake Patch" that is in release/2.6, I've also applied this patch there. Tested via GHA builds and local MinGW build. Your patch has been applied to the master and release/2.6 branch. commit a68595a582b2c6c220b4f4502753d5f4154000d8 (master) commit 19bfb

[Openvpn-devel] [M] Change in openvpn[master]: Remove compat versionhelpers.h and remove cmake/configure check for it

cron2 has uploaded a new patch set (#3) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/445?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Remove compat versionhelpers.h and remove cmake/con

Re: [Openvpn-devel] [M] Change in openvpn[master]: Remove compat versionhelpers.h and remove cmake/configure check for it

Make is original and don't change anything to make it affect please On Mon, Nov 20, 2023, 2:52 AM plaisthos (Code Review) wrote: > Attention is currently required from: flichtenheld. > > plaisthos would like flichtenheld to *review* this change. > > View Change

[Openvpn-devel] [PATCH applied] Re: Rename state_change to continue_tls_process

This is really straightforward rename + added comments. Gave it a full test nonetheless :-) One could argue that the debug print with "tls_process: chg=%d" could use an adjustment as well ("cont=%d"?). Your patch has been applied to the master branch. commit 8ba03f91388970754f3536866f9687759b07

[Openvpn-devel] [M] Change in openvpn[master]: Rename state_change to continue_tls_process

cron2 has uploaded a new patch set (#4) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/452?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Rename state_change to continue_tls_process ...

[Openvpn-devel] [M] Change in openvpn[master]: Rename state_change to continue_tls_process

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/452?usp=email ) Change subject: Rename state_change to continue_tls_process .. Rename state_change to continue_tls_process The name state_change is more c