[Openvpn-devel] [M] Change in openvpn[master]: Implement generating TLS 1.0 PRF using new OpenSSL 3.0 APIs

2023-11-22 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/457?usp=email to look at the new patch set (#3). Change subject: Implement generating TLS 1.0 PRF using new OpenSSL 3.0 APIs

Re: [Openvpn-devel] [PATCH v3] Add missing check for nl_socket_alloc failure

2023-11-22 Thread Antonio Quartulli
Hi, On 21/11/2023 18:06, Arne Schwabe wrote: This can happen if the memory alloc fails. Patch V2: add goto error Patch V3: return -ENOMEM instead of going to error Change-Id: Iee66caa794d267ac5f8bee584633352893047171 Signed-off-by: Arne Schwabe Acked-by: Antonio Quartulli --- src/openv

[Openvpn-devel] [S] Change in openvpn[master]: Fix unaligned access in macOS, FreeBSD, Solaris hwaddr

2023-11-22 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello cron2, flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/454?usp=email to look at the new patch set (#2). Change subject: Fix unaligned access in macOS, FreeBSD, Solaris

[Openvpn-devel] [S] Change in openvpn[master]: Minimal Solaris/OpenIndiana support to Cmake and clean up -Werror

2023-11-22 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/458?usp=email to review the following change. Change subject: Minimal Solaris/OpenIndiana support to Cmake and clean up -Werror ...

[Openvpn-devel] [PATCH master] Remove --tls-export-cert

2023-11-22 Thread David Sommerseth
From: David Sommerseth As OpenVPN 2.6+ is doing some adoptions to the license text, all prior contributors need to accept this new text. Unfortunately, Mathieu Giannecchini who implemented the --tls-export-cert feature did not respond at all. Without an explicit acceptance we need to remove thi

[Openvpn-devel] [PATCH release/2.6] Remove --tls-export-cert

2023-11-22 Thread David Sommerseth
From: David Sommerseth As OpenVPN 2.6+ is doing some adoptions to the license text, all prior contributors need to accept this new text. Unfortunately, Mathieu Giannecchini who implemented the --tls-export-cert feature did not respond at all. Without an explicit acceptance we need to remove thi

[Openvpn-devel] IRC community meeting summary

2023-11-22 Thread Johan Draaisma
Meeting summary for 22 November 2023: * *Closed: OpenVPN 2.6.7 release* /2.6.7 was released, and followed up with 2.6.8./ * *Closed: OpenVPN 2.6.8 release* /2.6.8 was released on Friday 17 November./ * *Updated: Publish security assessment of OpenVPN2 on main website.* /Trail of Bit

[Openvpn-devel] [M] Change in openvpn[master]: Remove dead list test code

2023-11-22 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/446?usp=email ) Change subject: Remove dead list test code .. Patch Set 1: Code-Review-1

[Openvpn-devel] [PATCH] Remove superfluous x509_write_pem()

2023-11-22 Thread David Sommerseth
From: David Sommerseth After removing --tls-export-cert, this function was left in the code base with no other users. This was an oversight in the previous change. Removing it to avoid leaving dead code behind. Signed-off-by: David Sommerseth --- src/openvpn/ssl_verify_backend.h | 11 ---

[Openvpn-devel] [PATCH] Remove superfluous x509_write_pem()

2023-11-22 Thread David Sommerseth
From: David Sommerseth After removing --tls-export-cert, this function was left in the code base with no other users. This was an oversight in the previous change. Removing it to avoid leaving dead code behind. Signed-off-by: David Sommerseth --- src/openvpn/ssl_verify_backend.h | 11 ---

[Openvpn-devel] [S] Change in openvpn[master]: Fix unaligned access in macOS, FreeBSD, Solaris hwaddr

2023-11-22 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/454?usp=email ) Change subject: Fix unaligned access in macOS, FreeBSD, Solaris hwaddr ..

Re: [Openvpn-devel] [PATCH release/2.6] Remove --tls-export-cert

2023-11-22 Thread Gert Doering
Hi, On Wed, Nov 22, 2023 at 03:31:10PM +0100, David Sommerseth wrote: > From: David Sommerseth > > As OpenVPN 2.6+ is doing some adoptions to the license text, all > prior contributors need to accept this new text. Unfortunately, Mathieu > Giannecchini who implemented the --tls-export-cert feat

[Openvpn-devel] [XS] Change in openvpn[master]: Fix check_session_buf_not_used using wrong index

2023-11-22 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/459?usp=email to review the following change. Change subject: Fix check_session_buf_not_used using wrong index .

Re: [Openvpn-devel] [PATCH release/2.6] Remove --tls-export-cert

2023-11-22 Thread David Sommerseth
On 22/11/2023 22:51, Gert Doering wrote: Hi, On Wed, Nov 22, 2023 at 03:31:10PM +0100, David Sommerseth wrote: From: David Sommerseth As OpenVPN 2.6+ is doing some adoptions to the license text, all prior contributors need to accept this new text. Unfortunately, Mathieu Giannecchini who impl