[Openvpn-devel] [PATCH v1] platform.c: Do not depend Windows build on HAVE_CHDIR

2023-11-11 Thread Gert Doering
From: Frank Lichtenheld This broke in the CMake build since previously we just always set HAVE_CHDIR to 1 in the MSVC build. But actually the code should just not check HAVE_CHDIR on Windows. Change-Id: I0c78ce452135fe2c80275da449215ba926471018 Signed-off-by: Frank Lichtenheld Acked-by: Lev Sti

[Openvpn-devel] [XS] Change in openvpn[master]: platform.c: Do not depend Windows build on HAVE_CHDIR

2023-11-11 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/425?usp=email ) Change subject: platform.c: Do not depend Windows build on HAVE_CHDIR .. platform.c: Do not depend Windows build on HAVE_CHDIR This broke

[Openvpn-devel] [PATCH applied] Re: platform.c: Do not depend Windows build on HAVE_CHDIR

2023-11-11 Thread Gert Doering
This patch will do the job, but I think (at least for "master") we should do a bit more thorough job - as in, get rid of HAVE_CHDIR completely, in autoconf, cmake, header files. There is no platform where we have a remote chance in getting OpenVPN ported that has no chdir(), so this is all a nice

[Openvpn-devel] [XS] Change in openvpn[master]: platform.c: Do not depend Windows build on HAVE_CHDIR

2023-11-11 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/425?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by stipa Change subject: platform.c: Do not depend Windows build on HAVE_CHDIR .

[Openvpn-devel] [XS] Change in openvpn[master]: Do not check key_state buffers that are in S_UNDEF state

2023-11-11 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/426?usp=email to review the following change. Change subject: Do not check key_state buffers that are in S_UNDEF state .

[Openvpn-devel] [M] Change in openvpn[master]: Enable key export with mbed TLS 3.x.y

2023-11-11 Thread plaisthos (Code Review)
Attention is currently required from: MaxF, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/402?usp=email ) Change subject: Enable key export with mbed TLS 3.x.y .. Patch Set

[Openvpn-devel] [PATCH applied] Re: doc: Correct typos in multiple documentation files

2023-11-11 Thread Gert Doering
Thanks. Your patch has been applied to the master and release/2.6 branch. commit 20c42b89f6d38a4426b5fe67f59acaadcb9ac314 (master) commit 457f468a76f324a14b1236988cc5f5a95f14abf5 (release/2.6) Author: Aquila Macedo Date: Thu Oct 19 16:40:49 2023 -0300 doc: Correct typos in multiple docume