Re: [Openvpn-devel] [PATCH] Log OpenSSL errors on failure to set certificate

2023-10-02 Thread Arne Schwabe
Am 01.10.23 um 19:49 schrieb selva.n...@gmail.com: From: Selva Nair Currently we log a bogus error message saying private key password verification failed when SSL_CTX_use_cert_and_key() fails in pkcs11_openssl.c. Instead print OpenSSL error queue and exit promptly. Also log OpenSSL errors whe

[Openvpn-devel] [S] Change in openvpn[master]: Log OpenSSL errors on failure to set certificate

2023-10-02 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#3) to the change originally created by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/363?usp=email ) Change subject: Log OpenSSL errors on failure to set certificate .. Log OpenSSL erro

[Openvpn-devel] [S] Change in openvpn[master]: Log OpenSSL errors on failure to set certificate

2023-10-02 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/363?usp=email ) Change subject: Log OpenSSL errors on failure to set certificate .. Log OpenSSL errors on failure to set certificate Currently we log a bo

[Openvpn-devel] [PATCH applied] Re: Log OpenSSL errors on failure to set certificate

2023-10-02 Thread Gert Doering
Good error messages are always an improvement, and not going on after a "cannot use this certificate" error is propably also a good idea (so, change M_WARN to M_FATAL makes sense). For the "test on many different OpenSSL versions and OSes" I have subjected this to the GH builds and my local MinGW