[Openvpn-devel] [XL] Change in openvpn[release/2.6]: CMake: backport CMake buildsystem from master to release/2.6

2023-09-26 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/315?usp=email ) Change subject: CMake: backport CMake buildsystem from master to release/2.6 .

[Openvpn-devel] [PATCH] CMake: backport CMake buildsystem from master to release/2.6

2023-09-26 Thread Frank Lichtenheld
This is based on the initial CMake patch by Arne Schwabe, but extends that to provide a complete replacement for existing MinGW build (autotools based) and MSVC build (openvpn.sln). The following features are added while switching these builds to CMake: - vcpkg support for MinGW build, allowing f

[Openvpn-devel] [M] Change in openvpn[master]: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patch...

2023-09-26 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, flichtenheld. Hello cron2, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/361?usp=email to look at the new patch set (#4). Change subject: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to

[Openvpn-devel] [M] Change in openvpn[master]: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patch...

2023-09-26 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, d12fk. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/361?usp=email ) Change subject: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patchwork

[Openvpn-devel] [PATCH applied] Re: CMake: backport CMake buildsystem from master to release/2.6

2023-09-26 Thread Gert Doering
A quick review shows that this is really only "Windows buildsystem and CMake" related stuff, no code changes - a number of "master" patches squashed together (introducing new files, now we've ironed out the bugs in master - let's not do the step-by-step thing here again, littel benefit and just ext

[Openvpn-devel] [PATCH applied] Re: Remove all traces of the previous MSVC build system

2023-09-26 Thread Gert Doering
And gone with the wind... :-) - getting rid of these complicated .xml files that we never managed to update on "there is a new source file!" is a big win. Tested via GH build (pass), local MinGW build (pass), and a linux "make dist(check)", since this fixes a number of "make dist does not include