Attention is currently required from: flichtenheld, stipa.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/362?usp=email )
Change subject: CMake: fix HAVE_DAEMON detection on Linux
..
Patch Se
From: Lev Stipakov
On Linux, daemon() is defined in unistd.h, not in
stdlib.h like in MacOS or FreeBSD.
Change-Id: I30f4ea502a36eca155cbc79b89c0d18ee3419877
Signed-off-by: Lev Stipakov
Acked-by: Gert Doering
---
This change was reviewed on Gerrit and approved by at least one
developer. I requ
Officially deprecated since v2.4.
We have warned about using this forever.
It is time to pull the plug.
Change-Id: I58706019add6d348483ba222dd74e1466ff6c709
Signed-off-by: Frank Lichtenheld
Acked-by: Heiko Hund
---
This change was reviewed on Gerrit and approved by at least one
developer. I req
We do this via explicit PRs now, generated by renovate.
This allows much better control over what state of the
code gets built.
Change-Id: I8b00d7d79a26ad4aaae529cb496e125398169b50
Signed-off-by: Frank Lichtenheld
Acked-by: Lev Stipakov
---
This change was reviewed on Gerrit and approved by at
From: Heiko Hund
No DNS resolver currently supports this and it is not possible to
emulate the behavior without the chance of errors. Finding the
effective default system DNS server(s) to specify the exclude
DNS routes is not trivial and cannot be verified to be correct
without resolver internal
From: Lev Stipakov
"INFO_PRE,..." command length is limited to 256 bytes. If the server
implementation pushes command which is too long, warn the user and
don't send the truncated command to a management client.
Change-Id: If3c27a2a2ba24f2af0e3e3c95eea57ed420b2542
Signed-off-by: Lev Stipakov
Ac
Attention is currently required from: cron2.
Hello cron2,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/361?usp=email
to look at the new patch set (#3).
Change subject: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to
Patchwork
Have not tested it beyond "test compile", but change looks reasonable.
Your patch has been applied to the master and release/2.6 branch
("make things more robust").
commit df624fb6d63db6b2a3b0c40597cee74c61b8ab2c (master)
commit 785b50127ecf0c440c016f85cef0c59f56894fc4 (release/2.6)
Author: Lev S
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/329?usp=email )
Change subject: Warn user if INFO control command is too long
..
Warn user if INFO control command is too long
"INFO_PRE,..." command leng
cron2 has uploaded a new patch set (#2) to the change originally created by
stipa. ( http://gerrit.openvpn.net/c/openvpn/+/329?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: Warn user if INFO control command is too long
.
.. as discussed on the list and on IRC, yes.
Your patch has been applied to the master and release/2.6 branch.
commit 1864a19e85d89bc0b34cb1c6eac186f3fe323c0b (master)
commit cd09e073752fbad5d70adc2af66a29c7ed99a9e9 (release/2.6)
Author: Frank Lichtenheld
Date: Fri Sep 22 12:39:36 2023 +0200
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/328?usp=email )
Change subject: GHA: do not trigger builds in openvpn-build anymore
..
GHA: do not trigger builds in openvpn-build anymore
We do this via
.. as discussed on the list and on IRC, yes.
*second attempt*, fixing the URL: in both commits, so new commit IDs...
Your patch has been applied to the master and release/2.6 branch.
commit 37d6c61a3decf64d0db1cd3d033483c9db5c4c91 (master)
commit 1782daa48e782469550e37e7cd7dab2ba4e4be8b (HEAD ->
cron2 has uploaded a new patch set (#2) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/328?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by stipa
Change subject: GHA: do not trigger builds in openvpn-build anymore
...
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/362?usp=email )
Change subject: CMake: fix HAVE_DAEMON detection on Linux
..
CMake: fix HAVE_DAEMON detection on Linux
On Linux, daemon() is defined in un
cron2 has uploaded a new patch set (#2) to the change originally created by
stipa. ( http://gerrit.openvpn.net/c/openvpn/+/362?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: CMake: fix HAVE_DAEMON detection on Linux
As discussed on IRC - the previous "cmake related" patch related to
"compat-daemon.c" was triggered by cmake not finding daemon() on Linux,
and this is fixing it.
Your patch has been applied to the master branch.
commit e363b393f2d1b72590666554e17d928c1603f8d5 (master)
Author: Lev Stipakov
Date:
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/281?usp=email )
Change subject: Remove --no-replay option
..
Remove --no-replay option
Officially deprecated since v2.4.
We have warned about using this f
flichtenheld has uploaded this change for review. (
http://gerrit.openvpn.net/c/openvpn/+/281?usp=email )
Change subject: Remove --no-replay option
..
Remove --no-replay option
Officially deprecated since v2.4.
We have warned
Given that people are supposed to use AEAD ciphers, and this was
incompatible all along, time to rip it out. Yes, someone will complain,
but there is no way around that
Subjected to my torture chamber, for good measure :-)
Your patch has been applied to the master branch.
commit 6d76218dd68
Change makes sense, and doesn't break any of the GH tests :-)
I have applied this to 2.6 as well, as it doesn't really make sense
to keep these options, pretending "an implementation might come" when
we already know they are going away.
Something strange has happened to the mailing list archive -
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/39?usp=email )
Change subject: dns option: remove support for exclude-domains
..
dns option: remove support for exclude-domains
No DNS resolver currently
cron2 has uploaded a new patch set (#7) to the change originally created by
d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/39?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by stipa
Change subject: dns option: remove support for exclude-domains
From: Arne Schwabe
Explicitly say that the version specified is the one of the peer and not
the version we try to emulate.
Change-Id: I3bd27a8d34d8cb4896a3b78508b7d16911571543
Acked-by: Frank Lichtenheld
Signed-off-by: Arne Schwabe
---
This change was reviewed on Gerrit and approved by at lea
Hi,
On Fri, Sep 22, 2023 at 03:48:00PM +0200, Frank Lichtenheld wrote:
> From: Arne Schwabe
>
> Explicitly say that the version specified is the one of the peer and not
> the version we try to emulate.
This has been merged ages ago ;-)
commit daf66f4013d8facc085ea6cfaaf8a42f4d45a461
Author: Ar
flichtenheld has abandoned this change. (
http://gerrit.openvpn.net/c/openvpn/+/34?usp=email )
Change subject: Improve description of compat-mode
..
Abandoned
merged with wrong Change-Id
--
To view, visit http://gerrit.openvpn
Contains the following commits:
- Make compatible with mingw build
(commit 17746e53f65249b42017256056c5415099df288d)
- Convert CONTROL to vcpkg.json
(commit a2160d3e42a1eff59aee3d984fd3354907f4379f)
- reference upstream PRs in patches
(commit 9577ffe92f033d8452cff0a3dbdfdc943655c5b8)
- rename
From: Selva Nair
- Do not use non-literal initializers for static objects
- Replace empty initializer {} by {0}
Change-Id: Ifb961a4df2b8b8300633192e1a268669f6f41a35
Signed-off-by: Selva Nair
Acked-by: Heiko Hund
Acked-by: Selva Nair
Acked-by: Lev Stipakov
Co-authored-by: Frank Lichtenheld
A
Since we use strlen() to determine the length
and then check it ourselves, there is really
no point in using strncpy.
But the compiler might complain that we use
the output of strlen() for the length of
strncpy which is usually a sign for bugs:
error: ‘strncpy’ specified bound depends
on the len
Acked-by: Gert Doering
I'm not sure how that works, and how to test it - but the description
matches what we agreed as being useful ("run the test each night, but
only if something new was pushed this day").
Your patch has been applied to the master and release/2.6 branch.
commit 607ae9b821665d
Attention is currently required from: d12fk.
Hello plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/313?usp=email
to look at the new patch set (#2).
Change subject: Mock openvpn_exece on win32 also for test_tls_crypt
...
Attention is currently required from: cron2, flichtenheld.
Hello cron2, d12fk, ordex,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/314?usp=email
to look at the new patch set (#2).
The change is no longer submittable: checks~ChecksSubmitRule is unsa
Attention is currently required from: d12fk.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/313?usp=email )
Change subject: Mock openvpn_exece on win32 also for test_tls_crypt
..
Patch
Attention is currently required from: flichtenheld.
d12fk has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/313?usp=email )
Change subject: Mock openvpn_exece on win32 also for test_tls_crypt
..
Patch
34 matches
Mail list logo
