[Openvpn-devel] [PATCH] ntlm: Clarify details on NTLM phase 3 decoding

2023-08-02 Thread David Sommerseth
From: David Sommerseth The code was very clear if we accept that the base64 decode of the NTLM challenge was truncated or not. Move the related code lines closer to where it first used and comment what we are not concerned about any truncation. If the decoded result is truncated, the NTLM serve

Re: [Openvpn-devel] [PATCH] ntlm: Clarify details on NTLM phase 3 decoding

2023-08-02 Thread David Sommerseth
On 02/08/2023 13:31, David Sommerseth wrote: From: David Sommerseth The code was very clear if we accept that the base64 decode of the There is a "not" missing in the line above: "The code was not very clear ..." I'm fine with fixing this at commit time. -- kind regards, David Sommerse

[Openvpn-devel] [PATCH] Check for client options

2023-08-02 Thread merten . fermont
From: Merten Fermont Require 'client' or 'tls-client'+'pull' to be declared in the config. To prevent other errors, 'client' option is added when 'tls-client' and 'pull' are both declared. Fixes error that --pull is a unknown option. --- openvpn/client/cliopt.hpp | 1 - openvpn/client/cl