[Openvpn-devel] [PATCH applied] Re: fix typo: dhcp-options to dhcp-option in vpn-network-options.rst

Acked-by: Gert Doering Trivially correct (verified against options.c), and correct documentation is important. Thanks, Frank, for forwarding. Your patch has been applied to the master, release/2.6 and release/2.5 branch. commit 9d2e947e7358c7998f13b142d8bf17a2ce9eb7a3 (master) commit 1e1e711f5

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: Fix '--inactive 0' behavior for DCO

stipa has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/201?usp=email ) Change subject: Fix '--inactive 0' behavior for DCO .. Fix '--inactive 0' behavior for DCO Make sure we exit if is 0 (not se

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Print DCO client stats on SIGUSR2

flichtenheld has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/202?usp=email ) Change subject: Print DCO client stats on SIGUSR2 .. Print DCO client stats on SIGUSR2 Change-Id: I465febdf7ee5fe573e88255844f718ef

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: Fix '--inactive 0' behavior for DCO

flichtenheld has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/201?usp=email ) Change subject: Fix '--inactive 0' behavior for DCO .. Fix '--inactive 0' behavior for DCO Make sure we exit if is 0 (not set) a

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Print DCO client stats on SIGUSR2

stipa has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/202?usp=email ) Change subject: Print DCO client stats on SIGUSR2 .. Print DCO client stats on SIGUSR2 Change-Id: I465febdf7ee5fe573e88255844f7

Re: [Openvpn-devel] [S] Change in openvpn[release/2.6]: Print DCO client stats on SIGUSR2

On Mon, Jul 17, 2023 at 02:17:17PM +, flichtenheld (Code Review) wrote: > flichtenheld has submitted this change. ( > http://gerrit.openvpn.net/c/openvpn/+/202?usp=email ) > > Change subject: Print DCO client stats on SIGUSR2 > .

[Openvpn-devel] [PATCH applied] Re: manage.c: document missing KID parameter

Since this is a pure textual change, I haven't tested this any way - and the change matches "Changes.rst" and "doc/management-notes.txt". Your patch has been applied to the master and release/2.6 branch. commit f5201eedd4ea55414bf8310668a3d00e7bf8ea71 (master) commit d3fe78af5dde169fcb13a6fde3b53

[Openvpn-devel] [PATCH applied] Re: Ignore Ipv6 route delete request on Android and set ipv4 verbosity to 7

Acked-by: Gert Doering "because it makes sense" Not tested beyond stare-at-code and have GHA do a test build, because this is all #ifdef TARGET_ANDROID, and "only msg() calls" at that. Uncrustify complains about indentation, so whitespace adjusted accordingly. Your patch has been applied to th

[Openvpn-devel] [PATCH applied] Re: Mock openvpn_exece on win32 also for test_tls_crypt

As requested, merged BEFORE that other thing, whatever it is, I'll find out :-) I had some confusion about this patch at first ("why is it moving that single function into a new file") and then I saw that it's being linked to two different test drivers now. So, makes sense. Tested by pushing to

[Openvpn-devel] [PATCH applied] Re: Check if the -wrap argument is actually supported by the platform's ld

Tested with GHA mingw/msvc builds, and the resulting unit test runs - all looks green. (As a side note, we *build* test_tls_crypt on Windows now, but the GHA "mingw unittests" runs do not seem to run it yet -> patch to build.yaml missing?) Your patch has been applied to the master branch. commit