Re: [Openvpn-devel] [PATCH 1/5] add basic CMake based build

2023-06-21 Thread Lev Stipakov
This doesn't change anything (apart from lzo includes) in existing build systems, so looks harmless. I have looked closer at the CMake changes in the follow-up patch. Acked-by: Lev Stipakov ti 20. kesäk. 2023 klo 16.55 Frank Lichtenheld (fr...@lichtenheld.com) kirjoitti: > > From: Arne Schwabe

Re: [Openvpn-devel] [PATCH v3 2/5] CMake: Add complete MinGW and MSVC build

2023-06-21 Thread Lev Stipakov
I have looked at the MSVC part and gave some suggestions, which are now implemented. I also tested openvpn.exe, openvpnserv.exe and tapctl.exe binaries - looks good. Acked-by: Lev Stipakov ti 20. kesäk. 2023 klo 16.55 Frank Lichtenheld (fr...@lichtenheld.com) kirjoitti: > > This is based on the

[Openvpn-devel] [PATCH applied] Re: dist: add more missing files only used in the MSVC build

2023-06-21 Thread Gert Doering
Acked-by: Gert Doering There is not much meat to the patch, except "bundle a few extra files", so this is what I tested. Diffing "make dist" created tarballs with and without this patch confirms "it adds vcpkg.json + git-version.py". Your patch has been applied to the master and release/2.6 bra

[Openvpn-devel] [PATCH applied] Re: vcpkg-ports/pkcs11-helper: rename patches to make file names shorter

2023-06-21 Thread Gert Doering
Acked-by: Gert Doering Indeed, this fixes bundling for the one patch with an extra-long name (so the tar file diffs have 2 file renames, plus one extra file). To verify whether things still build, I've run via local mingw build (works) and GHA (works). This does not apply to release/2.6, becaus

[Openvpn-devel] [PATCH applied] Re: unit_tests: Add missing cert_data.h to source list for unit tests

2023-06-21 Thread Gert Doering
Acked-by: Gert Doering "make sense". Verified that it still builds ;-) - and adds this extra file to the tarball. The patch does not apply to release/2.6, because the whole pkey_test_utils.c part is not part of 2.6. Your patch has been applied to the master branch. commit 97223cb057a0edfafd28

[Openvpn-devel] [PATCH applied] Re: dist: Include all documentation in distribution

2023-06-21 Thread Gert Doering
Acked-by: Gert Doering "Makes sense". If we have all these nice files, so well maintained, why not share them. (We might want to have a look into these doxygen files and see if part of the documentation has become stale over time... I have not seen any updates in a long time, except for copyri

[Openvpn-devel] [PATCH 2.6] unit_tests: Add missing cert_data.h to source list for unit tests

2023-06-21 Thread Frank Lichtenheld
Document the dependency. Also fixes cert_data.h missing from distribution. This is the "backport" of commit 97223cb057a0edfafd28b34427449bb3eda7d0be to release/2.6. Change-Id: Ib82208bfa12cc8ba5ff08b4c010bf398bc92d249 Signed-off-by: Frank Lichtenheld --- tests/unit_tests/openvpn/Makefile.am | 1

Re: [Openvpn-devel] [PATCH applied] Re: vcpkg-ports/pkcs11-helper: rename patches to make file names shorter

2023-06-21 Thread Frank Lichtenheld
On Wed, Jun 21, 2023 at 02:18:27PM +0200, Gert Doering wrote: > Acked-by: Gert Doering > > Indeed, this fixes bundling for the one patch with an extra-long name > (so the tar file diffs have 2 file renames, plus one extra file). > > To verify whether things still build, I've run via local mingw