Re: [Openvpn-devel] Automatically restart Linux systemd OpenVPN client service on failure

2023-05-15 Thread Melvin Vermeeren
Hi all, On Sunday, 14 May 2023 21:12:08 CEST David Sommerseth wrote: > We ended up only enabling this on the server config by default, as it > was some good points (which I don't recall right now) about not > restarting the client configs automatically. It might have been due to > avoid DDoS the

[Openvpn-devel] [PATCH] DCO: fix memory leak in dco_get_peer_stats_multi for Linux

2023-05-15 Thread Frank Lichtenheld
Leaks a small amount of memory every 15s. Signed-off-by: Frank Lichtenheld --- src/openvpn/dco_linux.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/openvpn/dco_linux.c b/src/openvpn/dco_linux.c index 796e6f25..2bfdf980 100644 --- a/src/openvpn/dco_linux.c +++ b/src

Re: [Openvpn-devel] [PATCH] DCO: fix memory leak in dco_get_peer_stats_multi for Linux

2023-05-15 Thread Antonio Quartulli
Hi, On 15/05/2023 16:21, Frank Lichtenheld wrote: Leaks a small amount of memory every 15s. Signed-off-by: Frank Lichtenheld wonderful catch, Frank! Acked-by: Antonio Quartulli --- src/openvpn/dco_linux.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/open

[Openvpn-devel] [PATCH] sample-plugins: Fix memleak in client-connect example plugin

2023-05-15 Thread Frank Lichtenheld
I was looking for memleaks in the code and found this one with cppcheck. Only an example, but no need to leave this bug in it. Also fix fortify problem in keying-material-exporter-demo so I can actually test the compilation of the sample plugins. Change-Id: Ibd1b282afc4a28768be3f165f84ab60ca4d24a

[Openvpn-devel] [PATCH] Fix two unused assignments

2023-05-15 Thread Frank Lichtenheld
A fallout of my memleak investigation. These are not leaks, we just assign a value that is never read before overwritten. Not critical, but since I already stumbled over it... Change-Id: I761ea3d289f49a20e42a3d1bfccebce3c7447afe Signed-off-by: Frank Lichtenheld --- src/openvpn/push.c | 1 - src/

[Openvpn-devel] [PATCH v2 2/3] CMake: Add complete MinGW and MSVC build

2023-05-15 Thread Frank Lichtenheld
This is based on the initial CMake patch by Arne Schwabe, but extends that to provide a complete replacement for existing MinGW build (autotools based) and MSVC build (openvpn.sln). The following features are added while switching these builds to CMake: - vcpkg support for MinGW build, allowing f

Re: [Openvpn-devel] [PATCH] sample-plugins: Fix memleak in client-connect example plugin

2023-05-15 Thread Gert Doering
Hi, On Mon, May 15, 2023 at 05:53:39PM +0200, Frank Lichtenheld wrote: > I was looking for memleaks in the code and found > this one with cppcheck. Only an example, but no > need to leave this bug in it. > > Also fix fortify problem in keying-material-exporter-demo > so I can actually test the co

Re: [Openvpn-devel] [PATCH v3] Add Apache2 linking with for new commits

2023-05-15 Thread Jeremie Courreges-Anglas
On Wed, Apr 26 2023, Arne Schwabe wrote: > After first round of mailing people with more than 10 commits we have > almost all committers have agreed. This put this license in the realm > of having a realistic change to work. Had any of these contributers > disagreed, rewriting all their code might

[Openvpn-devel] [PATCH] Correctly handle Unicode names for exit event

2023-05-15 Thread selva . nair
From: Selva Nair Currently we use the ANSI version of CreateEvent causing name of the exit event to be interpreted differently depending on the code page in effect. Internally all strings parsed from command line and config file are stored as UTF8-encoded Uniode. When passed to Windows API calls,