I have stared a bit at the code, and it all looks sane (though kp@ and
Antonio are the experts here, anyway :-) ). I have not tested things
beyond "passes client/server tests, with and without DCO" - my kernel
does not have the new code bits yet (and for a real tests, one would
have to modify it t
Acked-by: Gert Doering
"Because it makes sense".
Your patch has been applied to the master and release/2.6 branch.
commit 03174bea4805bc018190d56a96f750f72fd960c1 (master)
commit 3779cefe5d3636f722a4df51db6162fcc44e2dcd (release/2.6)
Author: Frank Lichtenheld
Date: Wed May 3 15:59:21 2023 +02
Acked-by: Gert Doering
t_client.sh is built according to configure findings for @SHELL etc.,
so no good packing it.
Verified that the tarball before/after only differs in "t_client.sh",
that "distcheck" still passes, and that "make check" on the resulting
tarball builds & runs a t_client.sh as e
Acked-by: Gert Doering
"because it makes sense".
I have not tested this beyond "does it still compile?" (which is just
paranoia since "it's only changing a single byte in a string", but hey...)
@Frank, thanks for forwarding this from a MR to the list.
Your patch has been applied to the master
Acked-by: Gert Doering
"Obviously correct". Wonder who ACKed and/or merged the offending code...
Interesting enough, Uncrustify does not complain here.
Your patch has been applied to the master and release/2.6 branch.
commit 8d38ed4817f4c1fe1676409c4e5138aaa4a69dfc (master)
commit a32f9140519
I have only tested this by subjecting to a MinGW and a GHA build (to make
sure I did not break the whitespace-broken patches on merge). Green!
Your patch has been applied to the master branch.
commit 17746e53f65249b42017256056c5415099df288d
Author: Frank Lichtenheld
Date: Fri Mar 31 17:42:12 2
I have no idea what this does, but if Lev says it's The Way...
It doesn't contain code changes, and I have verified that it doesn't
break MinGW or GH building, so fine with me.
Your patch has been applied to the master branch.
commit a2160d3e42a1eff59aee3d984fd3354907f4379f
Author: Frank Lichten
Looks reasonable and does not break any builds... :-)
Your patch has been applied to the master branch.
commit 9577ffe92f033d8452cff0a3dbdfdc943655c5b8
Author: Frank Lichtenheld
Date: Fri Mar 31 17:42:14 2023 +0200
vcpkg-ports/pkcs11-helper: reference upstream PRs in patches
Signed-
On 8 May 2023, at 13:55, Gert Doering wrote:
> I have stared a bit at the code, and it all looks sane (though kp@ and
> Antonio are the experts here, anyway :-) ). I have not tested things
> beyond "passes client/server tests, with and without DCO" - my kernel
> does not have the new code bits yet
