[Openvpn-devel] [PATCH applied] Re: Bug-fix: segfault in dco_get_peer_stats()

2023-03-28 Thread Gert Doering
Acked-by: Antonio Quartulli Thanks for the good find. Since I could reproduce the crash yesterday (and I do need management for it) I can verify that it does no longer crash with the patch. (For whatever reason, --tls-version-max 1.0 did not suffice to trigger the error this morning, but --tls-

Re: [Openvpn-devel] [PATCH] Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant

2023-03-28 Thread Frank Lichtenheld
On Mon, Mar 27, 2023 at 09:45:53PM +0200, Matthias Andree wrote: > Am 27.03.23 um 16:45 schrieb Selva Nair: > > Hi, > > > > On Mon, Mar 27, 2023 at 9:59 AM Matthias Andree > > wrote: > > > > Am 27.03.23 um 13:49 schrieb selva.n...@gmail.com: > > > From: Selva Nair > > > > > > -

Re: [Openvpn-devel] [PATCH] Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant

2023-03-28 Thread Matthias Andree
Am 28.03.23 um 10:47 schrieb Frank Lichtenheld: On Mon, Mar 27, 2023 at 09:45:53PM +0200, Matthias Andree wrote: Am 27.03.23 um 16:45 schrieb Selva Nair: Hi, On Mon, Mar 27, 2023 at 9:59 AM Matthias Andree wrote: Am 27.03.23 um 13:49 schrieb selva.n...@gmail.com: > From: Selva Nair

[Openvpn-devel] OpenVPN 2.6.2 released

2023-03-28 Thread Frank Lichtenheld
The OpenVPN community project team is proud to release OpenVPN 2.6.2. This is mostly a bugfix release with some improvements. Feature changes: * implement byte counter statistics for DCO Linux (p2mp server and client) * implement byte counter statistics for DCO Windows (client only) * "--dns ser

[Openvpn-devel] [PATCH] GHA: remove Ubuntu 18.04 builds

2023-03-28 Thread Frank Lichtenheld
Github will stop supporting them on April, 1st. Signed-off-by: Frank Lichtenheld --- .github/workflows/build.yaml | 15 --- 1 file changed, 15 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index a3ca7a2e..99ae437e 100644 --- a/.github/workflow

Re: [Openvpn-devel] [PATCH applied] Re: Bug-fix: segfault in dco_get_peer_stats()

2023-03-28 Thread Selva Nair
On Tue, Mar 28, 2023 at 3:25 AM Gert Doering wrote: > Acked-by: Antonio Quartulli > > Thanks for the good find. Since I could reproduce the crash yesterday > (and I do need management for it) I can verify that it does no longer > crash with the patch. > > (For whatever reason, --tls-version-max

Re: [Openvpn-devel] [PATCH] GHA: remove Ubuntu 18.04 builds

2023-03-28 Thread Matthias Andree
Am 28.03.23 um 12:09 schrieb Frank Lichtenheld: Github will stop supporting them on April, 1st. ACK nowledged. OpenPGP_signature Description: OpenPGP digital signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists

[Openvpn-devel] [PATCH applied] Re: GHA: remove Ubuntu 18.04 builds

2023-03-28 Thread Gert Doering
Your patch has been applied to the master and release/2.6 branch. commit cf7ff95d38cd702306857caf7232ccca64dd4eb4 (master) commit e5c436c2cb8a19d0a926aa14a2f2a31385f3eaee (release/2.6) Author: Frank Lichtenheld Date: Tue Mar 28 12:09:26 2023 +0200 GHA: remove Ubuntu 18.04 builds Sign

[Openvpn-devel] [PATCH] buffer: use memcpy in buf_catrunc

2023-03-28 Thread Frank Lichtenheld
Since we use strlen() to determine the length and then check it ourselves, there is really no point in using strncpy. But the compiler might complain that we use the output of strlen() for the length of strncpy which is usually a sign for bugs: error: ‘strncpy’ specified bound depends on the len

Re: [Openvpn-devel] [PATCH] buffer: use memcpy in buf_catrunc

2023-03-28 Thread Antonio Quartulli
Hi, On 28/03/2023 17:12, Frank Lichtenheld wrote: Since we use strlen() to determine the length and then check it ourselves, there is really no point in using strncpy. But the compiler might complain that we use the output of strlen() for the length of strncpy which is usually a sign for bugs:

Re: [Openvpn-devel] [PATCH] buffer: use memcpy in buf_catrunc

2023-03-28 Thread Matthias Andree
Am 28.03.23 um 17:12 schrieb Frank Lichtenheld: Since we use strlen() to determine the length and then check it ourselves, there is really no point in using strncpy. But the compiler might complain that we use the output of strlen() for the length of strncpy which is usually a sign for bugs: er

Re: [Openvpn-devel] [PATCH] buffer: use memcpy in buf_catrunc

2023-03-28 Thread Antonio Quartulli
Hi, On 28/03/2023 20:51, Matthias Andree wrote: Am 28.03.23 um 17:12 schrieb Frank Lichtenheld: Since we use strlen() to determine the length and then check it ourselves, there is really no point in using strncpy. But the compiler might complain that we use the output of strlen() for the lengt

Re: [Openvpn-devel] [PATCH] buffer: use memcpy in buf_catrunc

2023-03-28 Thread Matthias Andree
Am 28.03.23 um 20:58 schrieb Antonio Quartulli: Hi, On 28/03/2023 20:51, Matthias Andree wrote: Am 28.03.23 um 17:12 schrieb Frank Lichtenheld: Since we use strlen() to determine the length and then check it ourselves, there is really no point in using strncpy. But the compiler might complain