Acked-by: Gert Doering
"Trivially correct" :-) - compile-tested on a DCO enabled linux.
Your patch has been applied to the master and release/2.6 branch.
commit 23903fd579353c9892415a750f17a9832a79cced (master)
commit 047f772b84843344b6131e9e915472d14adcea2b (release/2.6)
Author: Antonio Quartu
On Mon, Mar 20, 2023 at 05:55:38PM +0100, Arne Schwabe wrote:
> Explicitly say that the version specified is the one of the peer and not
> the version we try to emulate.
>
> Patch v2: Improve grammar.
> Change-Id: I3bd27a8d34d8cb4896a3b78508b7d16911571543
>
> Change-Id: If4fb45b3426f5e0dbe6c87d5b
Hi Gert,
thanks very much!
> Have not investigated how to actually trigger these code lines.
If you're curious (TL;DR), below's a test FWIW:
The fix can be seen "in action" when using OpenVPN with a quantum-safe
signature algorithm via oqs-provider:
Everything built into docker images:
NAK.
When running with --disable-dco:
Program received signal SIGUSR2, User defined signal 2.
0x77aee967 in __GI___poll (fds=0x55668ca0, nfds=2,
timeout=1) at ../sysdeps/unix/sysv/linux/poll.c:29
29 ../sysdeps/unix/sysv/linux/poll.c: No such file or directory.
(gdb) c
Continu
The agreement with the DCO submodule is that no API should be called if
DCO is actually disabled. For this reason, every invocation must happen
only after having checked that dco_enabled() returns true.
Add missing checks before invoking dco_get_peer_stats_multi()
Reported-by: Lev Stipakov
Signe
LGTM.
Without this patch and with Linux DCO peer stats openvpn crashes, with
this patch it doesn't.
Acked-by: Lev Stipakov
ti 21. maalisk. 2023 klo 12.30 Antonio Quartulli (a...@unstable.cc) kirjoitti:
>
> The agreement with the DCO submodule is that no API should be called if
> DCO is actually
Nothing to test here :-)
Your patch has been applied to the master and release/2.6 branch.
commit daf66f4013d8facc085ea6cfaaf8a42f4d45a461 (master)
commit 92827ad84eb3a5b7ca70f3e7f34800d25790b10d (release/2.6)
Author: Arne Schwabe
Date: Mon Mar 20 17:55:38 2023 +0100
Improve description o
I have not tested this extensively (as in "instrument the functions
not called anymore if --disable-dco is in use"), just ran some basic
tests on FreeBSD 14 with DCO, and "counters with DCO" still work,
as does --inactive (with a "this many bytes" specification).
Your patch has been applied to the
I've submitted this to "basic client/server testing" plus "GHA build",
just to be sure that nothing breaks - but this doesn't excercise the
new code at all.
Stare-at-code says "it should do what it says on the lid", and the
code is actually a bit simpler this way, not having to maintain separate
a
With this API it is possible to retrieve the stats for a specific peer
or for all peers and then update the userspace counters with the value
reported by DCO.
Change-Id: Ia3990b86b1be7ca844fb1674b39ce0d60528ccff
Signed-off-by: Antonio Quartulli
---
Changes from v1:
* use m->instances[] instead o
When retrieving the multi_instance of a specific peer,
there is no need to peform a linear search across the
whole m->hash list. We can directly access the needed
object via m->instances[peer-id] in constant time (and
just one line of code).
Adapt the dco-freebsd code to do so.
Cc: Kristof Provos
Hi,
On 22/03/2023 00:10, Antonio Quartulli wrote:
When retrieving the multi_instance of a specific peer,
there is no need to peform a linear search across the
whole m->hash list. We can directly access the needed
object via m->instances[peer-id] in constant time (and
just one line of code).
Ada
Am 22.03.23 um 00:10 schrieb Antonio Quartulli:
When retrieving the multi_instance of a specific peer,
there is no need to peform a linear search across the
whole m->hash list. We can directly access the needed
object via m->instances[peer-id] in constant time (and
just one line of code).
Adapt
13 matches
Mail list logo
