Re: [Openvpn-devel] [PATCH 1/5] Conditionally add subdir-objects option to automake

2023-02-08 Thread Arne Schwabe
Am 08.02.2023 um 01:40 schrieb Selva Nair: On Tue, Feb 7, 2023 at 7:18 PM Arne Schwabe wrote: From: Selva Nair - Eliminates repeated warnings such as   warning: source file '$(openvpn_srcdir)/env_set.c' is in a subdirectory,   but option 'subdir-objects' is disabled

Re: [Openvpn-devel] [PATCH v2 3/3] Add a unit test for functions in cryptoapi.c

2023-02-08 Thread Arne Schwabe
Am 08.02.23 um 02:05 schrieb Selva Nair: Hi, On Tue, Feb 7, 2023 at 7:18 PM Arne Schwabe > wrote: Am 04.02.23 um 07:40 schrieb selva.n...@gmail.com : > From: Selva Nair mailto:selva.n...@gmail.com>> > > - Though named

Re: [Openvpn-devel] [PATCH v3 2/3] Build unit tests in mingw Windows build

2023-02-08 Thread Arne Schwabe
Am 08.02.23 um 01:59 schrieb selva.n...@gmail.com: From: Selva Nair - Minor changes to the build system to include some dependencies for Windows build - test_tls_crypt not built as it will pull in win32.c and its dependencies - If cross-compiling, "make check" will only build the tests

Re: [Openvpn-devel] [PATCH v2 3/3] Add a unit test for functions in cryptoapi.c

2023-02-08 Thread Selva Nair
On Wed, Feb 8, 2023 at 6:16 AM Arne Schwabe wrote: > Am 08.02.23 um 02:05 schrieb Selva Nair: > > Hi, > > > > On Tue, Feb 7, 2023 at 7:18 PM Arne Schwabe > > wrote: > > > > Am 04.02.23 um 07:40 schrieb selva.n...@gmail.com > > : > >

Re: [Openvpn-devel] [PATCH 5/5] Add building and running mingw unittests to github actions

2023-02-08 Thread Selva Nair
Hi, It's "absolutely splendid" to see cross-compiled tests running in GHA! Some issues below: On Tue, Feb 7, 2023 at 7:19 PM Arne Schwabe wrote: > Signed-off-by: Arne Schwabe > --- > .github/workflows/build.yaml | 110 ++- > 1 file changed, 108 insertions(+),