[Openvpn-devel] [PATCH] openvpnmsica: remove unused declarations

2023-01-24 Thread Lev Stipakov
From: Lev Stipakov That code has been moved to MSM by commit 640c4d82 ("openvpnmsica: remove dco installer custom actions") Signed-off-by: Lev Stipakov --- src/openvpnmsica/openvpnmsica.h | 26 -- 1 file changed, 26 deletions(-) diff --git a/src/openvpnmsica/openvpnmsi

[Openvpn-devel] [PATCH applied] Re: openvpnmsica: remove unused declarations

2023-01-24 Thread Gert Doering
Acked-by: Gert Doering Quite straightforward - "if the code is gone, we do not need prototypes in .h files either" :-) Not tested anything (beyond "push to mygithub" to be sure I did not overlook a ";" or anything). Your patch has been applied to the master and release/2.6 branch. commit 6effd

[Openvpn-devel] [PATCH] openvpnmsica: fix adapters discovery logic for DCO

2023-01-24 Thread Lev Stipakov
From: Lev Stipakov Custom action "FindSystemInfo" finds adapters with certain hwid and assigns found adapters' guids to a certain property. Later another custom action "EvaluateTUNTAPAdapters" schedules adapter creation if the abovementioned property is not set - which means no adapters exist wit

Re: [Openvpn-devel] [PATCH] openvpnmsica: fix adapters discovery logic for DCO

2023-01-24 Thread Arne Schwabe
The ultimate solution to this would be moving adapter creation to MSM, a shared component which adds/removes the DCO driver. However this change is not trivial and requires a lot of work. For the time being we apply this band-aid by excluding Connect-created adapters from enumerations in "Find

Re: [Openvpn-devel] [PATCH] openvpnmsica: fix adapters discovery logic for DCO

2023-01-24 Thread Selva Nair
Hi, On Tue, Jan 24, 2023 at 9:25 AM Lev Stipakov wrote: > From: Lev Stipakov > > Custom action "FindSystemInfo" finds adapters with certain hwid and > assigns found adapters' guids to a certain property. Later another custom > action "EvaluateTUNTAPAdapters" schedules adapter creation if the >

Re: [Openvpn-devel] [PATCH] openvpnmsica: fix adapters discovery logic for DCO

2023-01-24 Thread Lev Stipakov
Hi, >> I think this logic is needed to prevent duplicate adapter creation >> if adapter was renamed and then new version is installed. > > Is the driver still always updated (i.e., when update required) even if the > adapter is not created because of existing ones found? At the moment yes. Moreo