Re: [Openvpn-devel] [PATCH] Undo FreeBSD 12.x workaround on IPv6 ifconfig for 12.4 and up

2023-01-06 Thread Arne Schwabe
Am 27.12.22 um 23:35 schrieb Gert Doering: commit 5e19cc2c1bf22d introduced a workaround for a race condition that showed itself on IPv6 ifconfig on FreeBSD 12.x - sometimes breaking IPv6 connectivity on tun/tap interfaces. This was fixed on the FreeBSD side in 12.4, 13.1 and up, and 13.0 is no

Re: [Openvpn-devel] [PATCH v4 4/5] Fix signal handling on Windows

2023-01-06 Thread Lev Stipakov
Looks good, Tested with an unresolvable hostname - I was able to break during restart pause, unlike before. 2023-01-06 13:49:53 us=46000 SIGUSR1[soft,Could not determine IPv4/IPv6 protocol] received, process restarting 2023-01-06 13:49:53 us=46000 Restart pause, 16 second(s) C:\Users\lev\Project

Re: [Openvpn-devel] [PATCH 1/3] Use IPAPI for setting ipv6 routes when iservice not available

2023-01-06 Thread Lev Stipakov
Hi, Compiled and slightly tested - pinged server's tunnel IPv6 address. Acked-by: Lev Stipakov ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH 2/3] Distinguish route addition errors from route already exists

2023-01-06 Thread Lev Stipakov
Hi, > else if ((flags & ROUTE_METHOD_MASK) == ROUTE_METHOD_IPAPI) > { > status = add_route_ipapi(r, tt, ai); > -msg(D_ROUTE, "Route addition via IPAPI %s", status ? "succeeded" > : "failed"); > +msg(D_ROUTE, "Route addition via IPAPI %s", (st

[Openvpn-devel] [PATCH v2] Add connect-freq-initial option to limit initial connection responses

2023-01-06 Thread Arne Schwabe
This limits the nubmer of packets OpenVPN will respond to. This avoid OpenVPN server being abused for refelection attacks in a large scale as we gotten a lot more efficient with the cookie approach in our initial connection approach. The defaults of 100 attempts per 10s should work for most people

Re: [Openvpn-devel] [PATCH 2/3] Distinguish route addition errors from route already exists

2023-01-06 Thread Selva Nair
On Fri, Jan 6, 2023 at 9:16 AM Lev Stipakov wrote: > Hi, > > > else if ((flags & ROUTE_METHOD_MASK) == ROUTE_METHOD_IPAPI) > > { > > status = add_route_ipapi(r, tt, ai); > > -msg(D_ROUTE, "Route addition via IPAPI %s", status ? > "succeeded" : "failed");

Re: [Openvpn-devel] [PATCH 1/3] dco: properly re-initialize dco_del_peer_reason

2023-01-06 Thread Arne Schwabe
Am 03.01.23 um 21:23 schrieb Antonio Quartulli: After processing a message, all fields of the dco object should be re-initialized so that future processings are not affected by stale values. This includes dco_del_peer_reason. Since its values can start at 0, re-initialize it with -1. Acked-By

[Openvpn-devel] [PATCH v2 2/3] Distinguish route addition errors from route already exists

2023-01-06 Thread selva . nair
From: Selva Nair When possible, functions that add a route now return 1 on success, or 2 if route already exists or 0 on other errors instead of true/false. Note: net_route_v4/v6_add using netlink filters out EEXIST before returning this looks like a bug as add_route() and add_route_ipv6() shoul

Re: [Openvpn-devel] [PATCH 2/3] dco: bail out when no peer-specific message is delivered

2023-01-06 Thread Arne Schwabe
Am 03.01.23 um 21:23 schrieb Antonio Quartulli: multi_process_incoming_dco() is currently partly processing messages that were actually discarded. This results in a bogus message being printed: "Received packet for peer-id unknown to OpenVPN: -1, type 0, reason 2" Change the flow so that we bai

Re: [Openvpn-devel] [PATCH 3/3] dco: improve comment about hidden debug message

2023-01-06 Thread Arne Schwabe
Am 03.01.23 um 21:23 schrieb Antonio Quartulli: While at it also improve the debug message itself to be more self-explanatory. Signed-off-by: Antonio Quartulli --- src/openvpn/multi.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/openvpn/multi.c b/src/

Re: [Openvpn-devel] [PATCH 3/5] Assign and honour signal priority order

2023-01-06 Thread Arne Schwabe
Am 01.01.23 um 22:51 schrieb selva.n...@gmail.com: From: Selva Nair Signals are ordered as SIGUSR2, SIGUSR1, SIGHUP, SIGTERM, SIGINT in increasing priority. Lower priority signals are not allowed to overwrite higher ones. This should fix Trac #311, #639 -- SIGTER/SIGINT lost during dns resolut

Re: [Openvpn-devel] [PATCH] Undo FreeBSD 12.x workaround on IPv6 ifconfig for 12.4 and up

2023-01-06 Thread Gert Doering
Hi, On Fri, Jan 06, 2023 at 11:32:31AM +0100, Arne Schwabe wrote: > > +#if defined(TARGET_FREEBSD) && __FreeBSD_version >= 120 \ > > + && __FreeBSD_version <= 120 > > +/* On FreeBSD 12.0-12.3, there is ipv6_activate_all_interfaces="YES" > > > That does not look right. Should the se

Re: [Openvpn-devel] [PATCH 1/3] Use IPAPI for setting ipv6 routes when iservice not available

2023-01-06 Thread Gert Doering
Hi, On Fri, Jan 06, 2023 at 03:44:24PM +0200, Lev Stipakov wrote: > Compiled and slightly tested - pinged server's tunnel IPv6 address. Do we call "route" for connect networks on Windows? We do on some of the platforms, but for those where we do not, this is not a good test for "route add" funct

Re: [Openvpn-devel] [PATCH 1/3] Use IPAPI for setting ipv6 routes when iservice not available

2023-01-06 Thread Selva Nair
On Fri, Jan 6, 2023 at 3:19 PM Gert Doering wrote: > Hi, > > On Fri, Jan 06, 2023 at 03:44:24PM +0200, Lev Stipakov wrote: > > Compiled and slightly tested - pinged server's tunnel IPv6 address. > > Do we call "route" for connect networks on Windows? We do on some > of the platforms, but for tho