[Openvpn-devel] [PATCH applied] Re: Use dedicated multi->dco_peer_id for DCO instead of multi->peer_id

2022-11-28 Thread Gert Doering
Acked-by: Gert Doering This patch survived all tests I threw at it (Linux and FreeBSD client and server, with and without DCO, including multiple p2mp clients on the server under test). The "main" code change (dco_peer_id) is fairly straightforward, if one checks for the right values of "-1". T

Re: [Openvpn-devel] [PATCH] Add section about common error with OpenVPN 2.6 and OpenSSL 3.0

2022-11-28 Thread Frank Lichtenheld
On Sun, Nov 27, 2022 at 09:32:28PM +0100, Arne Schwabe wrote: > We expect a number of configuration to no longer work with OpenVPN > 2.6 and OpenSSL 3.0. This section tries to explain the most common > errors that will come up and how to work around them. > > Signed-off-by: Arne Schwabe > --- >

[Openvpn-devel] [PATCH v2] Update PORTS

2022-11-28 Thread Gert Doering
Instead of fully removing PORTS, keep "this is what you want to do for porting OpenVPN to a new platform" section, and update the PLATFORMS part to better reflect current status. v2: drop "2.2+" from Linux, and name the fruitish thing "macOS" Signed-off-by: Gert Doering --- PORTS | 43 +++

Re: [Openvpn-devel] [PATCH v2] Update PORTS

2022-11-28 Thread Frank Lichtenheld
On Mon, Nov 28, 2022 at 12:16:42PM +0100, Gert Doering wrote: > Instead of fully removing PORTS, keep "this is what you want to do for > porting OpenVPN to a new platform" section, and update the PLATFORMS > part to better reflect current status. > > v2: > drop "2.2+" from Linux, and name the fr

[Openvpn-devel] [PATCH applied] Re: Update PORTS

2022-11-28 Thread Gert Doering
Thanks for the review. Patch has been applied to the master branch. commit 16d773eb1f94179b60d718f1eb92cb14ace67779 Author: Gert Doering Date: Mon Nov 28 12:16:42 2022 +0100 Update PORTS Signed-off-by: Gert Doering Acked-by: Frank Lichtenheld Message-Id: <20221128111642.

[Openvpn-devel] new P2P NCP wart...

2022-11-28 Thread Gert Doering
Hi, if I provoke an error by having one side of p2p tls OpenVPN "with default options" (= AES-GCM) and call the client side with --data-ciphers BF-CBC --auth SHA256 then - as it is expected - the negotiation fails 2022-11-28 12:50:09 P2P mode NCP negotiation result: TLS_export=1, DATA_v2=1,

Re: [Openvpn-devel] new P2P NCP wart...

2022-11-28 Thread Gert Doering
Hi, On Mon, Nov 28, 2022 at 12:55:54PM +0100, Gert Doering wrote: > 2022-11-28 12:55:25 us=199080 ERROR: failed to negotiate cipher with peer and > --data-ciphers-fallback not enabled. No usable data channel cipher > 2022-11-28 12:55:25 us=199092 ERROR: Failed to apply P2P negotiated protocol >

Re: [Openvpn-devel] [PATCH 3/3] Call dco_p2p_add_new_peer again if the peer id changes

2022-11-28 Thread Gert Doering
Hi, On Wed, Oct 12, 2022 at 03:34:56PM +0200, Arne Schwabe wrote: > This allows a reconnect in p2p mode and has the side effect of updating > the peer address with the peerid Maybe I am just holding it wrong, but the patch does not change the situation for my p2p reconnection problem. First conn

Re: [Openvpn-devel] [PATCH 3/3] Call dco_p2p_add_new_peer again if the peer id changes

2022-11-28 Thread Gert Doering
Hi, On Mon, Nov 28, 2022 at 02:26:31PM +0100, Gert Doering wrote: > On Wed, Oct 12, 2022 at 03:34:56PM +0200, Arne Schwabe wrote: > > This allows a reconnect in p2p mode and has the side effect of updating > > the peer address with the peerid > > Maybe I am just holding it wrong, but the patch do

Re: [Openvpn-devel] [PATCH 3/3] Call dco_p2p_add_new_peer again if the peer id changes

2022-11-28 Thread Gert Doering
Hi, On Mon, Nov 28, 2022 at 02:35:24PM +0100, Gert Doering wrote: > Now testing the actual patch. Doesn't work... without 3/3, I have the ubuntu2004 kernel: [22034799.495703] ovpn_udp_encap_recv: received data from unknown peer (id: 1114473) on reconnect, but at least TLS handshake succeeds

[Openvpn-devel] [PATCH] rework INSTALL and README to prepare for 2.6 release

2022-11-28 Thread Gert Doering
Update URLs in README Rip out information in INSTALL that is already in PORTS, or is printed by "./configure --help" Update tun/tap driver information where outdated or incomplete. Update build prerequisites, add new linux libraries, add git and libtool to developer tools needed, etc. Signed-of