[Openvpn-devel] [PATCH applied] Re: Allow setting control channel packet size with max-packet-size

2022-11-06 Thread Gert Doering
Stared-at-code, discussed with Arne on IRC. There's a few things one could have done differently (like, using constrain_int() inside tls_init_control_channel_frame_parameters()), but this is all minor. Tested regular t_client and server side tests (which are not excercising the new option) - all

[Openvpn-devel] [PATCH applied] Re: Always include ACKs for the last seen control packets

2022-11-06 Thread Gert Doering
Applying Frank's ACK on v1 to v2, since the code is the same - just context changes, and renaming of lru to mru. Ran through server and client side testing, all works. This also adds a unit test, which is very welcome :-) - complex stuff, this, and not really easy to test ("I need to drop ACK #3

[Openvpn-devel] [PATCH applied] Re: Add workaround for Softether server dropping P_ACK_V1 with >= 5 acks

2022-11-06 Thread Gert Doering
Acked-by: Gert Doering This is straightforward. The detection "what makes a softether server?" is a bit annoying... and this code will be with us forever... I have not specifically tested this ("no softether server around") but ran the normal server/client tests. Your patch has been applied to