Re: [Openvpn-devel] [PATCH] ovpn-dco: fix kernel 6.1 compile issue in ovpn_peer_create

2022-10-22 Thread Antonio Quartulli
Hi John, Thanks a lot for your contribution! However, we can't have #ifs like that in the middle of the code, as this code is expected to go upstream (and #ifs on the kernel version are not allowed). The code should always work with the latest kernel version, while any magic compatibility t

[Openvpn-devel] [PATCH v2] ovpn-dco: fix kernel 6.1 compile issue in ovpn_peer_create

2022-10-22 Thread John Thomson
Linux 5.19 replaces netif_tx_napi_add, but maintains a definition to the new function in: 58caed3dacb4 ("netdev: reshuffle netif_napi_add() APIs to allow dropping weigh") [0] Linux 6.1 removes netif_tx_napi_add in c3f760ef1287 ("net: remove netif_tx_napi_add()") [1] [0]: https://git.kernel.org/p

Re: [Openvpn-devel] [PATCH v2] ovpn-dco: fix kernel 6.1 compile issue in ovpn_peer_create

2022-10-22 Thread Antonio Quartulli
Hi, On 22/10/2022 10:38, John Thomson wrote: Linux 5.19 replaces netif_tx_napi_add, but maintains a definition to the new function in: 58caed3dacb4 ("netdev: reshuffle netif_napi_add() APIs to allow dropping weigh") [0] Linux 6.1 removes netif_tx_napi_add in c3f760ef1287 ("net: remove netif_tx_

[Openvpn-devel] [PATCH v2] close_tun: print interface type consistently in message

2022-10-22 Thread Antonio Quartulli
When closing the tunnel interface we know if we were using DCO or not. for this reason we can customize the closing message and make it consistent with the opening one. Signed-off-by: Antonio Quartulli --- Changes from v1: * use termary if instead of full blown if block --- src/openvpn/init.c |

Re: [Openvpn-devel] [PATCH v2] ovpn-dco: fix kernel 6.1 compile issue in ovpn_peer_create

2022-10-22 Thread John Thomson
On Sat, 22 Oct 2022, at 13:38, Antonio Quartulli wrote: > Hi, > > On 22/10/2022 10:38, John Thomson wrote: >> Linux 5.19 replaces netif_tx_napi_add, but maintains a definition to the >> new function in: 58caed3dacb4 ("netdev: reshuffle netif_napi_add() APIs >> to allow dropping weigh") [0] >> >> L